[GitHub] [groovy] melix commented on pull request #1382: Make the Gradle build more idiomatic

[GitBox <gi...@apache.org>]

melix commented on pull request #1382:
URL: https://github.com/apache/groovy/pull/1382#issuecomment-701697763


   @paulk-asert @danielsun1106 I'm setting this for review despite CI failing, I'm not 100% sure why the `dist` command on GH action fails, maybe it's just too late.
   
   As you can see this PR ended up being much larger than I initially wanted it to be. In order to migrate to the `maven-publish` plugin, I ended up refactoring the build to make it cleaner, more idiomatic. Work is not complete but I could spend weeks on that.
   
   The new build is, IMO, much easier to understand. I tried to remove bad practices I found, and I tested that I could publish on a local artifactory server with signing. The new publications are richer and use Gradle Module Metadata.
   
   Also I took the liberty to remove the "backports" modules. Reintroducing wouldn't be too hard, but AFAIK they haven't really been used, and now there's only a 2.3 backport, and we're talking about Groovy 4.
   
   I'm going to continue a bit on this but I'd appreciate that you play a bit with this branch to find out if they are obvious problems: during the refactoring it's possible I've slightly changed the outputs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org