You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/10/02 17:33:26 UTC
[6/8] impala git commit: IMPALA-7532: Add catalogd client backoff
time into impalad CLI options
IMPALA-7532: Add catalogd client backoff time into impalad CLI options
Impala may fail queries or fail to start if the connection to catalogd
cannot be estabilished. Impala already has a retrial mechanism but the
backoff time is currently 0. This patch adds an option
"catalog_client_rpc_retry_interval_ms" for it, defaulting to 10 seconds.
Change-Id: I924c1f2fd37021f4c8fb6b46aa278ac4b1aee131
Reviewed-on: http://gerrit.cloudera.org:8080/11543
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/ade399c0
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/ade399c0
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/ade399c0
Branch: refs/heads/master
Commit: ade399c08f5a74f87d192b47d2b65c3b56d05f7c
Parents: de39b03
Author: Tianyi Wang <tw...@cloudera.com>
Authored: Fri Sep 28 15:41:26 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Tue Oct 2 00:53:49 2018 +0000
----------------------------------------------------------------------
be/src/runtime/exec-env.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/ade399c0/be/src/runtime/exec-env.cc
----------------------------------------------------------------------
diff --git a/be/src/runtime/exec-env.cc b/be/src/runtime/exec-env.cc
index dd46789..5e15990 100644
--- a/be/src/runtime/exec-env.cc
+++ b/be/src/runtime/exec-env.cc
@@ -129,6 +129,8 @@ DEFINE_int32(backend_client_rpc_timeout_ms, 300000, "(Advanced) The underlying "
DEFINE_int32(catalog_client_connection_num_retries, 3, "Retry catalog connections.");
DEFINE_int32(catalog_client_rpc_timeout_ms, 0, "(Advanced) The underlying TSocket "
"send/recv timeout in milliseconds for a catalog client RPC.");
+DEFINE_int32(catalog_client_rpc_retry_interval_ms, 10000, "(Advanced) The time to wait "
+ "before retrying when the catalog RPC client fails to connect to catalogd.");
const static string DEFAULT_FS = "fs.defaultFS";
@@ -155,7 +157,8 @@ ExecEnv::ExecEnv(int backend_port, int krpc_port,
FLAGS_backend_client_rpc_timeout_ms, FLAGS_backend_client_rpc_timeout_ms, "",
!FLAGS_ssl_client_ca_certificate.empty())),
catalogd_client_cache_(
- new CatalogServiceClientCache(FLAGS_catalog_client_connection_num_retries, 0,
+ new CatalogServiceClientCache(FLAGS_catalog_client_connection_num_retries,
+ FLAGS_catalog_client_rpc_retry_interval_ms,
FLAGS_catalog_client_rpc_timeout_ms, FLAGS_catalog_client_rpc_timeout_ms, "",
!FLAGS_ssl_client_ca_certificate.empty())),
htable_factory_(new HBaseTableFactory()),