[jira] [Commented] (OAK-3070) Use a lower bound in VersionGC query to avoid checking unmodified once deleted docs

["Marcel Reutegger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889825#comment-15889825 ] 

Marcel Reutegger commented on OAK-3070:
---------------------------------------

bq. So, what I'm proposing is that we do both OAK-5704 and OAK-3070 in trunk and backport only OAK-3070.

I like this idea. We have to be careful though how OAK-3070 and OAK-5704 interact when OAK-3070 is backported and an upgrade happens later. Such a repository would have documents representing resurrected nodes older than the lower bound for the VersionGC. Would Oak ignore the lower bound after the upgrade and OAK-5704 resets the _deletedOnce flags of those documents?

> Use a lower bound in VersionGC query to avoid checking unmodified once deleted docs
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-3070
>                 URL: https://issues.apache.org/jira/browse/OAK-3070
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk, rdbmk
>            Reporter: Chetan Mehrotra
>            Assignee: Vikas Saurabh
>              Labels: performance
>         Attachments: OAK-3070.patch, OAK-3070-updated.patch, OAK-3070-updated.patch
>
>
> As part of OAK-3062 [~mreutegg] suggested
> {quote}
> As a further optimization we could also limit the lower bound of the _modified
> range. The revision GC does not need to check documents with a _deletedOnce
> again if they were not modified after the last successful GC run. If they
> didn't change and were considered existing during the last run, then they
> must still exist in the current GC run. To make this work, we'd need to
> track the last successful revision GC run. 
> {quote}
> Lowest last validated _modified can be possibly saved in settings collection and reused for next run



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)