[GitHub] [nifi-minifi-cpp] arpadboda edited a comment on issue #716: MINIFICPP-1127 - Provenance repo performance should be improved

[GitBox <gi...@apache.org>]

arpadboda edited a comment on issue #716: MINIFICPP-1127 - Provenance repo performance should be improved
URL: https://github.com/apache/nifi-minifi-cpp/pull/716#issuecomment-581920115
 
 
   > It would be prudent to have some tests for at least the cleanup behaviour of the ProvenanceRepository, and it shouldn't be too hard to create.
   > 
   > Please also see my inline comment.
   
   If you provide a reasonable time to wait for after inserting the records to make sure rocksdb background tasks completed the cleanup I'm happy to do so. :)
   Although the "3 secs should be good" approach is not something I would follow, that's the best way to introduce unstable tests. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services