You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/21 14:29:18 UTC

[jira] [Commented] (FLINK-3458) Shading broken in flink-shaded-hadoop

    [ https://issues.apache.org/jira/browse/FLINK-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156017#comment-15156017 ] 

ASF GitHub Bot commented on FLINK-3458:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1681

    [FLINK-3458] [build] Disable shade-flink execution in flink-shaded-hadoop

    The `shade-flink` execution of the parent pom caused the problem that the guava
    dependencies were relocated twice in the flink-shaded-hadoop jar. In order to
    avoid this, this patch disables the `shade-flink` execution.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixShading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1681
    
----
commit 834d352d62b1502d36bdf67d885fd874a70cb073
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-17T13:59:16Z

    [FLINK-3458] [build] Disable shade-flink execution in flink-shaded-hadoop
    
    The shade-flink execution of the parent pom caused the problem that the guava
    dependencies were relocated twice in the flink-shaded-hadoop jar. In order to
    avoid this, this patch disables the shade-flink execution.

----


> Shading broken in flink-shaded-hadoop
> -------------------------------------
>
>                 Key: FLINK-3458
>                 URL: https://issues.apache.org/jira/browse/FLINK-3458
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> The shading in flink-shaded-hadoop relocates the guava dependencies of Hadoop twice.
> Once under {{org.apache.flink.shaded.hadoop.com.google}} and {{org.apache.flink.shaded.com.google}}. This causes merge resolution problems when building a fat jar including the flink-shaded-hadoop jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)