[GitHub] anirudh2290 commented on a change in pull request #12374: Fix/public internal header

[GitBox <gi...@apache.org>]

anirudh2290 commented on a change in pull request #12374: Fix/public internal header
URL: https://github.com/apache/incubator-mxnet/pull/12374#discussion_r214191762
 
 

 ##########
 File path: include/mxnet/random_generator.h
 ##########
 @@ -150,14 +149,9 @@ class RandGenerator<gpu, DType> {
     curandStatePhilox4_32_10_t state_;
   };  // class RandGenerator<gpu, DType>::Impl
 
-  static void AllocState(RandGenerator<gpu, DType> *inst) {
-    CUDA_CALL(cudaMalloc(&inst->states_,
-                         kNumRandomStates * sizeof(curandStatePhilox4_32_10_t)));
-  }
+  static void AllocState(RandGenerator<gpu, DType> *inst);
 
 Review comment:
   @apeforest are you indicating about perf advantages during compile time ? I think its okay to put the definition in random_generator.cu since we don't want to expose cuda_utils.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services