[GitHub] [superset] eschutho commented on pull request #18131: refactor(reports): refactoring reports

[GitBox <gi...@apache.org>]

eschutho commented on pull request #18131:
URL: https://github.com/apache/superset/pull/18131#issuecomment-1039713076


   @AAfghahi this looks great. I'm trying not to get greedy with too many changes at once. I think we can merge this and maybe clean up a little bit on the final merge. The only thing that seems like perhaps a mistake that we may want to address in this PR is the comment here: `return currentReport?.error;`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org