You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/10 22:31:53 UTC

[GitHub] tillrohrmann commented on a change in pull request #7072: [FLINK-10821] Fix resume from externalized checkpoints E2E Test

tillrohrmann commented on a change in pull request #7072: [FLINK-10821] Fix resume from externalized checkpoints E2E Test
URL: https://github.com/apache/flink/pull/7072#discussion_r232468084
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_resume_externalized_checkpoints.sh
 ##########
 @@ -125,9 +126,20 @@ fi
 
 echo "Restoring job with externalized checkpoint at $CHECKPOINT_PATH ..."
 
-BASE_JOB_CMD=`buildBaseJobCmd $NEW_DOP`
+BASE_JOB_CMD=`buildBaseJobCmd $NEW_DOP "-s file://${CHECKPOINT_PATH}"`
+JOB_CMD=""
+if [[ $SIMULATE_FAILURE == "true" ]]; then
 
 Review comment:
   Why do we construct a failing job for the recovery step? Wouldn't a simple job which tests the resuming without explicit failure be sufficient?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services