You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/08 10:40:26 UTC

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5818: [IOTDB-3108]Optimize register process of datanode

qiaojialin commented on code in PR #5818:
URL: https://github.com/apache/iotdb/pull/5818#discussion_r867470466


##########
server/src/main/java/org/apache/iotdb/db/client/ConfigNodeClient.java:
##########
@@ -169,10 +168,17 @@ public TDataNodeRegisterResp registerDataNode(TDataNodeRegisterReq req)
     for (int i = 0; i < RETRY_NUM; i++) {
       try {
         TDataNodeRegisterResp resp = client.registerDataNode(req);
-        if (!updateConfigNodeLeader(resp.status)) {
+
+        // check if config nodes are inconsistent

Review Comment:
   describe more detail, confignode_list fetched from ConfigNode are inconsistent with which?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org