[GitHub] [beam] emilymye commented on a change in pull request #15330: [BEAM-12683] & [BEAM-12733] failing integration tests for Recommendation AI

[GitBox <gi...@apache.org>]

emilymye commented on a change in pull request #15330:
URL: https://github.com/apache/beam/pull/15330#discussion_r689704511



##########
File path: sdks/python/apache_beam/ml/gcp/recommendations_ai_test_it.py
##########
@@ -40,6 +40,16 @@
 
 GCP_TEST_PROJECT = 'apache-beam-testing'
 
+CATALOG_ITEM = {
+    "id": str(int(random.randrange(100000))),

Review comment:
       Do we want to choose a different id than this? if we can do a string, could we have something like a date or descriptive ID prefix? Maybe `"aitest-%s-%d" % (datetime.now(). strftime("%Y%m%d-%H%M"), int(random.randint(1,10000)))` or something.
   
   I also think that moving this to be global makes it harder to have multiple TestCases that create catalog items, but I'm not sure if we'll really be doing more tests. Would it make sense to have cleanup clean multiple items and not worry about the ID? like list + for each delete




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org