You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/07/28 11:08:15 UTC
[jira] Created: (HARMONY-1004) [classlib][nio] Remove two magic
numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
[classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
-----------------------------------------------------------------------------------------------
Key: HARMONY-1004
URL: http://issues.apache.org/jira/browse/HARMONY-1004
Project: Harmony
Issue Type: Test
Components: Classlib
Reporter: Andrew Zhang
Private methods assertSocketActionBeforeConnect(DatagramSocket s) and assertSocketActionAfterConnect(DatagramSocket s) contain magic number , which may cause test fail because of port confliction. i.e.
"this.datagramSocket2 = new DatagramSocket(1082);"
Addtionally, these magic numbers are not necessary at all.
I'll upload to fix this problem soon.
Thanks!
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1004) [classlib][nio] Remove two magic
numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1004?page=all ]
Paulex Yang reassigned HARMONY-1004:
------------------------------------
Assignee: Paulex Yang
> [classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
> -----------------------------------------------------------------------------------------------
>
> Key: HARMONY-1004
> URL: http://issues.apache.org/jira/browse/HARMONY-1004
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: nio.diff
>
>
> Private methods assertSocketActionBeforeConnect(DatagramSocket s) and assertSocketActionAfterConnect(DatagramSocket s) contain magic number , which may cause test fail because of port confliction. i.e.
> "this.datagramSocket2 = new DatagramSocket(1082);"
> Addtionally, these magic numbers are not necessary at all.
> I'll upload to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1004) [classlib][nio] Remove two magic
numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1004?page=all ]
Paulex Yang resolved HARMONY-1004.
----------------------------------
Resolution: Fixed
Andrew, patch applied at revision r427413, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
> -----------------------------------------------------------------------------------------------
>
> Key: HARMONY-1004
> URL: http://issues.apache.org/jira/browse/HARMONY-1004
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: nio.diff
>
>
> Private methods assertSocketActionBeforeConnect(DatagramSocket s) and assertSocketActionAfterConnect(DatagramSocket s) contain magic number , which may cause test fail because of port confliction. i.e.
> "this.datagramSocket2 = new DatagramSocket(1082);"
> Addtionally, these magic numbers are not necessary at all.
> I'll upload to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1004) [classlib][nio] Remove two magic
numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1004?page=all ]
Paulex Yang closed HARMONY-1004.
--------------------------------
Verified by Andrew.
> [classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
> -----------------------------------------------------------------------------------------------
>
> Key: HARMONY-1004
> URL: http://issues.apache.org/jira/browse/HARMONY-1004
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: nio.diff
>
>
> Private methods assertSocketActionBeforeConnect(DatagramSocket s) and assertSocketActionAfterConnect(DatagramSocket s) contain magic number , which may cause test fail because of port confliction. i.e.
> "this.datagramSocket2 = new DatagramSocket(1082);"
> Addtionally, these magic numbers are not necessary at all.
> I'll upload to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1004) [classlib][nio] Remove two magic
numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1004?page=comments#action_12424723 ]
Andrew Zhang commented on HARMONY-1004:
---------------------------------------
Hi Paulex,
The fix looks fine. Thanks!
Best regards,
Andrew
> [classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
> -----------------------------------------------------------------------------------------------
>
> Key: HARMONY-1004
> URL: http://issues.apache.org/jira/browse/HARMONY-1004
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: nio.diff
>
>
> Private methods assertSocketActionBeforeConnect(DatagramSocket s) and assertSocketActionAfterConnect(DatagramSocket s) contain magic number , which may cause test fail because of port confliction. i.e.
> "this.datagramSocket2 = new DatagramSocket(1082);"
> Addtionally, these magic numbers are not necessary at all.
> I'll upload to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1004) [classlib][nio] Remove two magic
numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1004?page=all ]
Andrew Zhang updated HARMONY-1004:
----------------------------------
Attachment: nio.diff
Hi,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][nio] Remove two magic numbers from o.a.h.tests.java.nio.channels.DatagramChannelTest
> -----------------------------------------------------------------------------------------------
>
> Key: HARMONY-1004
> URL: http://issues.apache.org/jira/browse/HARMONY-1004
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: nio.diff
>
>
> Private methods assertSocketActionBeforeConnect(DatagramSocket s) and assertSocketActionAfterConnect(DatagramSocket s) contain magic number , which may cause test fail because of port confliction. i.e.
> "this.datagramSocket2 = new DatagramSocket(1082);"
> Addtionally, these magic numbers are not necessary at all.
> I'll upload to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira