You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Antonio Petrelli <an...@gmail.com> on 2007/05/23 17:28:56 UTC
Test build failures
Hi all!
I built the current STRUTS_2_0_X branch and I have 14 failures when
running tests.
Is it a known issue?
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test build failures
Posted by Musachy Barroso <mu...@gmail.com>.
can't help there, I always build xwork skipping the tests :)
musachy
On 5/23/07, Antonio Petrelli <an...@gmail.com> wrote:
>
> 2007/5/23, Musachy Barroso <mu...@gmail.com>:
> > I was having some failing test until the other day when I got the latest
> > from svn and compiled xwork, and they were related to i18 and the URL
> tag.
>
>
> Mmm... it's getting worse.
> I checked out the xwork project, and it does not install due to test
> failures...
>
> What's happening?
>
> Here is the list:
>
> Results :
>
> Failed tests:
> testParseValidators(
> com.opensymphony.xwork2.validator.ValidatorFactoryTest)
> testContextIsOverriddenByContextParamInValidationXML(
> com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
> testCollectionValidation(
> com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
> testBeanMessagesUseBeanResourceBundle(
> com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
> testArrayValidation(
> com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
> testContextIsPropagated(
> com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
> testShortCircuitNoErrors(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testGetValidatorsFromInterface(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testGetValidatorsForInterface(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testFieldErrorsOrder(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testMessageInterpolation(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testSameAliasWithDifferentClass(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testBuildsValidatorsForAliasError(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testDefaultMessageInterpolation(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testActionLevelShortCircuit(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testBuildsValidatorsForAlias(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testSkipAllActionLevelShortCircuit2(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testSkipUserMarkerActionLevelShortCircuit(
> com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
> testModelFieldErrorsAddedWithoutFieldPrefixForInterface(
> com.opensymphony.xwork2.validator.VisitorFieldValidatorModelTest)
> testModelFieldErrorsAddedWithoutFieldPrefix(
> com.opensymphony.xwork2.validator.VisitorFieldValidatorModelTest)
> testExpressionValidatorFailure(
> com.opensymphony.xwork2.validator.ExpressionValidatorTest)
> testExpressionValidationOfStringLength(
> com.opensymphony.xwork2.validator.ExpressionValidatorTest)
> testExpressionValidatorSuccess(
> com.opensymphony.xwork2.validator.ExpressionValidatorTest)
> testRangeValidation(
> com.opensymphony.xwork2.validator.DateRangeValidatorTest)
> testSkipAllActionLevelShortCircuit2(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testBuildsValidatorsForAlias(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testShortCircuitNoErrors(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testActionLevelShortCircuit(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testDefaultMessageInterpolation(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testSkipUserMarkerActionLevelShortCircuit(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testSameAliasWithDifferentClass(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testMessageInterpolation(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testGetValidatorsForInterface(
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
> testModelDrivenValidation(
> com.opensymphony.xwork2.validator.ModelDrivenValidationTest)
> testAnnotatedMethodFailure(
> com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
> testNotAnnotatedMethodSuccess2(
> com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
> testAnnotatedMethodSuccess(
> com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
> testNotAnnotatedMethodSuccess(
> com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
> testAnnotatedMethodSuccess2(
> com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
> testAnnotatedMethodSuccess3(
> com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
> testLookingUpFieldNameAsTextKey(
> com.opensymphony.xwork2.validator.SimpleActionValidationTest)
> testAliasValidation(
> com.opensymphony.xwork2.validator.SimpleActionValidationTest)
> testSubPropertiesAreValidated(
> com.opensymphony.xwork2.validator.SimpleActionValidationTest)
> testMessageKey(
> com.opensymphony.xwork2.validator.SimpleActionValidationTest)
> testParamterizedMessage(
> com.opensymphony.xwork2.validator.SimpleActionValidationTest)
> testParser(com.opensymphony.xwork2.validator.ValidatorFileParserTest)
> testParserActionLevelValidatorsShouldBeBeforeFieldLevelValidators(
> com.opensymphony.xwork2.validator.ValidatorFileParserTest)
> testRequiredStringWithNullValue(
> com.opensymphony.xwork2.validator.StringValidatorTest)
> testStringLength(com.opensymphony.xwork2.validator.StringValidatorTest)
> testRequiredString(com.opensymphony.xwork2.validator.StringValidatorTest
> )
> testRangeValidationWithError(
> com.opensymphony.xwork2.validator.DoubleRangeValidatorTest)
> testRangeValidationNoError(
> com.opensymphony.xwork2.validator.DoubleRangeValidatorTest)
> testRangeValidation(
> com.opensymphony.xwork2.validator.IntRangeValidatorTest)
>
> Tests run: 527, Failures: 53, Errors: 0, Skipped: 0
>
> Antonio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: Test build failures
Posted by Antonio Petrelli <an...@gmail.com>.
2007/5/23, Musachy Barroso <mu...@gmail.com>:
> I was having some failing test until the other day when I got the latest
> from svn and compiled xwork, and they were related to i18 and the URL tag.
Mmm... it's getting worse.
I checked out the xwork project, and it does not install due to test failures...
What's happening?
Here is the list:
Results :
Failed tests:
testParseValidators(com.opensymphony.xwork2.validator.ValidatorFactoryTest)
testContextIsOverriddenByContextParamInValidationXML(com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
testCollectionValidation(com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
testBeanMessagesUseBeanResourceBundle(com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
testArrayValidation(com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
testContextIsPropagated(com.opensymphony.xwork2.validator.VisitorFieldValidatorTest)
testShortCircuitNoErrors(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testGetValidatorsFromInterface(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testGetValidatorsForInterface(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testFieldErrorsOrder(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testMessageInterpolation(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testSameAliasWithDifferentClass(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testBuildsValidatorsForAliasError(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testDefaultMessageInterpolation(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testActionLevelShortCircuit(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testBuildsValidatorsForAlias(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testSkipAllActionLevelShortCircuit2(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testSkipUserMarkerActionLevelShortCircuit(com.opensymphony.xwork2.validator.DefaultActionValidatorManagerTest)
testModelFieldErrorsAddedWithoutFieldPrefixForInterface(com.opensymphony.xwork2.validator.VisitorFieldValidatorModelTest)
testModelFieldErrorsAddedWithoutFieldPrefix(com.opensymphony.xwork2.validator.VisitorFieldValidatorModelTest)
testExpressionValidatorFailure(com.opensymphony.xwork2.validator.ExpressionValidatorTest)
testExpressionValidationOfStringLength(com.opensymphony.xwork2.validator.ExpressionValidatorTest)
testExpressionValidatorSuccess(com.opensymphony.xwork2.validator.ExpressionValidatorTest)
testRangeValidation(com.opensymphony.xwork2.validator.DateRangeValidatorTest)
testSkipAllActionLevelShortCircuit2(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testBuildsValidatorsForAlias(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testShortCircuitNoErrors(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testActionLevelShortCircuit(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testDefaultMessageInterpolation(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testSkipUserMarkerActionLevelShortCircuit(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testSameAliasWithDifferentClass(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testMessageInterpolation(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testGetValidatorsForInterface(com.opensymphony.xwork2.validator.AnnotationActionValidatorManagerTest)
testModelDrivenValidation(com.opensymphony.xwork2.validator.ModelDrivenValidationTest)
testAnnotatedMethodFailure(com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
testNotAnnotatedMethodSuccess2(com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
testAnnotatedMethodSuccess(com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
testNotAnnotatedMethodSuccess(com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
testAnnotatedMethodSuccess2(com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
testAnnotatedMethodSuccess3(com.opensymphony.xwork2.validator.ValidatorAnnotationTest)
testLookingUpFieldNameAsTextKey(com.opensymphony.xwork2.validator.SimpleActionValidationTest)
testAliasValidation(com.opensymphony.xwork2.validator.SimpleActionValidationTest)
testSubPropertiesAreValidated(com.opensymphony.xwork2.validator.SimpleActionValidationTest)
testMessageKey(com.opensymphony.xwork2.validator.SimpleActionValidationTest)
testParamterizedMessage(com.opensymphony.xwork2.validator.SimpleActionValidationTest)
testParser(com.opensymphony.xwork2.validator.ValidatorFileParserTest)
testParserActionLevelValidatorsShouldBeBeforeFieldLevelValidators(com.opensymphony.xwork2.validator.ValidatorFileParserTest)
testRequiredStringWithNullValue(com.opensymphony.xwork2.validator.StringValidatorTest)
testStringLength(com.opensymphony.xwork2.validator.StringValidatorTest)
testRequiredString(com.opensymphony.xwork2.validator.StringValidatorTest)
testRangeValidationWithError(com.opensymphony.xwork2.validator.DoubleRangeValidatorTest)
testRangeValidationNoError(com.opensymphony.xwork2.validator.DoubleRangeValidatorTest)
testRangeValidation(com.opensymphony.xwork2.validator.IntRangeValidatorTest)
Tests run: 527, Failures: 53, Errors: 0, Skipped: 0
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test build failures
Posted by Musachy Barroso <mu...@gmail.com>.
It seems like the implementation of HashMap changed, and now the iterator
doesn't return the elements in the order it used to in 1.5, I guess we
should use a LinkedHashMap.
musachy
On 5/23/07, Antonio Petrelli <an...@gmail.com> wrote:
>
> 2007/5/23, Antonio Petrelli <an...@gmail.com>:
> > 2007/5/23, Antonio Petrelli <an...@gmail.com>:
> > > BTW, I forgot to tell that I was using JDK 1.6.0u1
> >
> > This seems to be the problem!
> > I tried using JDK 1.5.0 and tests went all OK.
> > I think that I will open an issue for that. Maybe it's not critical
> > (Struts 2 is built using JDK 1.5 right?) but it needs to be fixed.
>
> Here it is:
> https://issues.apache.org/struts/browse/WW-1942
>
> Have fun :-)
> Antonio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: Test build failures
Posted by Antonio Petrelli <an...@gmail.com>.
2007/5/23, Antonio Petrelli <an...@gmail.com>:
> 2007/5/23, Antonio Petrelli <an...@gmail.com>:
> > BTW, I forgot to tell that I was using JDK 1.6.0u1
>
> This seems to be the problem!
> I tried using JDK 1.5.0 and tests went all OK.
> I think that I will open an issue for that. Maybe it's not critical
> (Struts 2 is built using JDK 1.5 right?) but it needs to be fixed.
Here it is:
https://issues.apache.org/struts/browse/WW-1942
Have fun :-)
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test build failures
Posted by Antonio Petrelli <an...@gmail.com>.
2007/5/23, Antonio Petrelli <an...@gmail.com>:
> BTW, I forgot to tell that I was using JDK 1.6.0u1
This seems to be the problem!
I tried using JDK 1.5.0 and tests went all OK.
I think that I will open an issue for that. Maybe it's not critical
(Struts 2 is built using JDK 1.5 right?) but it needs to be fixed.
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test build failures
Posted by Musachy Barroso <mu...@gmail.com>.
>
> Uh wait a minute! The Struts 2 project in 2_0_X depends on XWork
> 2.0.2, not on a snapshot dependency. Installing XWork does not make
> sense then.
yeah that's true, I was referring to 2.1, mea culpa
musachy
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: Test build failures
Posted by Antonio Petrelli <an...@gmail.com>.
2007/5/23, Musachy Barroso <mu...@gmail.com>:
> I was having some failing test until the other day when I got the latest
> from svn and compiled xwork, and they were related to i18 and the URL tag.
Uh wait a minute! The Struts 2 project in 2_0_X depends on XWork
2.0.2, not on a snapshot dependency. Installing XWork does not make
sense then.
As an update, I tried to install Struts 2_0_X on my Linux machine and
I get 10 failures (instead of 12).
BTW, I forgot to tell that I was using JDK 1.6.0u1
Here are the results:
Results :
Failed tests:
testIncludeParameterInResultWithConditionParseOn(org.apache.struts2.dispatcher.ServletActionRedirectResultTest)
testIncludeParameterInResult(org.apache.struts2.dispatcher.ServletActionRedirectResultTest)
testRequestURIActionIncludeGet(org.apache.struts2.views.jsp.URLTagTest)
testAddParameters(org.apache.struts2.views.jsp.URLTagTest)
testParamPrecedenceWithAnchor(org.apache.struts2.views.jsp.URLTagTest)
testParamPrecedence(org.apache.struts2.views.jsp.URLTagTest)
testRequestURINoActionIncludeAll(org.apache.struts2.views.jsp.URLTagTest)
testRequestURIActionIncludeAll(org.apache.struts2.views.jsp.URLTagTest)
testNoActionIncludeGet(org.apache.struts2.views.jsp.URLTagTest)
testResourceUrlWithTwoNestedParam(org.apache.struts2.views.jsp.PortletUrlTagTest)
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test build failures
Posted by Musachy Barroso <mu...@gmail.com>.
I was having some failing test until the other day when I got the latest
from svn and compiled xwork, and they were related to i18 and the URL tag.
musachy
On 5/23/07, Antonio Petrelli <an...@gmail.com> wrote:
>
> 2007/5/23, Musachy Barroso <mu...@gmail.com>:
> > Did you build xwork also or you are using the one from the maven repo?
>
> I am using the one from the repository, do you think this is the problem?
>
> Antonio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: Test build failures
Posted by Antonio Petrelli <an...@gmail.com>.
2007/5/23, Musachy Barroso <mu...@gmail.com>:
> Did you build xwork also or you are using the one from the maven repo?
I am using the one from the repository, do you think this is the problem?
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Test build failures
Posted by Musachy Barroso <mu...@gmail.com>.
Did you build xwork also or you are using the one from the maven repo?
musachy
On 5/23/07, Antonio Petrelli <an...@gmail.com> wrote:
>
> 2007/5/23, Musachy Barroso <mu...@gmail.com>:
> >
> > Which ones? Bamboo is not complaining (oh, and that guy does know how to
> > complain :) )
>
>
>
> Results :
>
> Failed tests:
> testIncludeParameterInResultWithConditionParseOn(
> org.apache.struts2.dispatcher
> .ServletActionRedirectResultTest)
> testIncludeParameterInResult(
> org.apache.struts2.dispatcher.ServletActionRedirectResultTest)
> testTransform4WithDocumentInclude(
> org.apache.struts2.views.xslt.XSLTResultTest)
> testRequestURIActionIncludeGet(org.apache.struts2.views.jsp.URLTagTest)
> testAddParameters(org.apache.struts2.views.jsp.URLTagTest)
> testParamPrecedenceWithAnchor(org.apache.struts2.views.jsp.URLTagTest)
> testParamPrecedence(org.apache.struts2.views.jsp.URLTagTest)
> testRequestURINoActionIncludeAll(org.apache.struts2.views.jsp.URLTagTest
> )
> testRequestURIActionIncludeAll(org.apache.struts2.views.jsp.URLTagTest)
> testNoActionIncludeGet(org.apache.struts2.views.jsp.URLTagTest)
> testGetThemePropsThroughFileSystem(
> org.apache.struts2.components.template.BaseTemplateEngineTest)
> testResourceUrlWithTwoNestedParam(
> org.apache.struts2.views.jsp.PortletUrlTagTest)
>
> And sorry, they are 12, not 14...
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: Test build failures
Posted by Antonio Petrelli <an...@gmail.com>.
2007/5/23, Musachy Barroso <mu...@gmail.com>:
>
> Which ones? Bamboo is not complaining (oh, and that guy does know how to
> complain :) )
Results :
Failed tests:
testIncludeParameterInResultWithConditionParseOn(
org.apache.struts2.dispatcher
.ServletActionRedirectResultTest)
testIncludeParameterInResult(
org.apache.struts2.dispatcher.ServletActionRedirectResultTest)
testTransform4WithDocumentInclude(
org.apache.struts2.views.xslt.XSLTResultTest)
testRequestURIActionIncludeGet(org.apache.struts2.views.jsp.URLTagTest)
testAddParameters(org.apache.struts2.views.jsp.URLTagTest)
testParamPrecedenceWithAnchor(org.apache.struts2.views.jsp.URLTagTest)
testParamPrecedence(org.apache.struts2.views.jsp.URLTagTest)
testRequestURINoActionIncludeAll(org.apache.struts2.views.jsp.URLTagTest)
testRequestURIActionIncludeAll(org.apache.struts2.views.jsp.URLTagTest)
testNoActionIncludeGet(org.apache.struts2.views.jsp.URLTagTest)
testGetThemePropsThroughFileSystem(
org.apache.struts2.components.template.BaseTemplateEngineTest)
testResourceUrlWithTwoNestedParam(
org.apache.struts2.views.jsp.PortletUrlTagTest)
And sorry, they are 12, not 14...
Re: Test build failures
Posted by Musachy Barroso <mu...@gmail.com>.
Which ones? Bamboo is not complaining (oh, and that guy does know how to
complain :) )
musachy
On 5/23/07, Antonio Petrelli <an...@gmail.com> wrote:
>
> Hi all!
> I built the current STRUTS_2_0_X branch and I have 14 failures when
> running tests.
> Is it a known issue?
>
> Antonio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd