You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by GitBox <gi...@apache.org> on 2020/10/17 20:17:39 UTC

[GitHub] [xerces-c] ffontaine opened a new pull request #23: fix static linking with curl

ffontaine opened a new pull request #23:
URL: https://github.com/apache/xerces-c/pull/23


   When curl is statically built with openssl support, xerces needs to
   link with openssl libraries so use pkg_check_modules to get any
   needed dependencies
   
   Fixes:
    - http://autobuild.buildroot.org/results/29ca90fff2c8e38f2edf7240eca3aa3fe7397c45
   
   [Retrieved from:
   https://git.buildroot.net/buildroot/tree/package/xerces/0002-fix-static-linking-with-curl.patch]
   Signed-off-by: Fabrice Fontaine <fo...@gmail.com>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org

[GitHub] [xerces-c] rleigh-codelibre commented on pull request #23: fix static linking with curl

Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #23:
URL: https://github.com/apache/xerces-c/pull/23#issuecomment-711079959


   I'm not keen on replacing the standard FindCURL.cmake with pkg-config.  It's less portable, and I would also suspect it will not export the dependency properly for reuse in downstream projects linking against xerces.  This needs to work on Windows as well as UNIX.
   
   If FindCURL.cmake isn't working properly, I would suggest that the preferred course of action should be to fix its behaviour rather than work around it.  This will ensure it will work correctly in all projects linking libCURL, rather than selectively changing a single project to work around the problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org

[GitHub] [xerces-c] rleigh-codelibre commented on pull request #23: fix static linking with curl

Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #23:
URL: https://github.com/apache/xerces-c/pull/23#issuecomment-924648605


   Note that with the merging of #34 we now use the CURL imported target to link against.  Please could you retest and see if this PR is still necessary?
   
   Thanks,
   Roger


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org