You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/02 16:55:56 UTC

[GitHub] [cloudstack] GutoVeronezi opened a new pull request, #6603: Close restore and attach form right after receiving the job id

GutoVeronezi opened a new pull request, #6603:
URL: https://github.com/apache/cloudstack/pull/6603

   ### Description
   
   When restoring and attaching a backup volume, the UI waits for the successfful response of the API to close the formulary. However, letting the form open after sending the command can confuse users, that might try to send the command again.
   
   Note: other formularies (like volume or snapshot creation) always are closed after sending the command to the backend.
   
   With this PR, we intend to close the formulary right after sending the command, as done with others.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   
   It was tested in a local lab.
   
   Before the changes, I tried to restore and attach a backup volume. After clicking the button `Ok`, the command was sent, but the formulary was kept open. After the changes, when clicking the button `Ok`, the command is sent and the formulary is closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6603: Close restore and attach form right after receiving the job id

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6603:
URL: https://github.com/apache/cloudstack/pull/6603#issuecomment-1202993873

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6603 (SL-JID-2057)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] acs-robot commented on pull request #6603: Close restore and attach form right after receiving the job id

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6603:
URL: https://github.com/apache/cloudstack/pull/6603#issuecomment-1202987826

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud merged pull request #6603: Close restore and attach form right after receiving the job id

Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6603:
URL: https://github.com/apache/cloudstack/pull/6603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6603: Close restore and attach form right after receiving the job id

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6603:
URL: https://github.com/apache/cloudstack/pull/6603#issuecomment-1202988536

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org