You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/08/02 18:22:36 UTC

[GitHub] storm pull request #2255: [STORM-2672] Expose a metric for calls to reportEr...

GitHub user Ethanlm opened a pull request:

    https://github.com/apache/storm/pull/2255

    [STORM-2672] Expose a metric for calls to reportError()

    See: https://issues.apache.org/jira/browse/STORM-2672
    
    Add a metric for calls to reportError.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ethanlm/storm STORM-2672

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2255
    
----
commit 60609026aa9ea4b31cf6a383a52f3ac9ddfa80d5
Author: Ethan Li <et...@gmail.com>
Date:   2017-08-02T14:22:33Z

    [STORM-2672] Expose a metric for calls to reportError()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2255: [STORM-2672] Expose a metric for calls to reportEr...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2255


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2255: [STORM-2672] Expose a metric for calls to reportError()

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2255
  
    @roshannaik  Could you please let me know what issues you are talking about?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2255: [STORM-2672] Expose a metric for calls to reportError()

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2255
  
    Yes. Will do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2255: [STORM-2672] Expose a metric for calls to reportError()

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2255
  
    Could you update the metrics documentation to include the new metric?  This is new and under `docs/Metrics.md`
    
    otherwise the change looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2255: [STORM-2672] Expose a metric for calls to reportError()

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2255
  
    Could you update the metrics documentation to include the new metric?  This is new and under `docs/Metrics.md`
    
    otherwise the change looks good +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---