You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/02 23:36:54 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #14006: Document configuration for email backend credentials.

mik-laj commented on a change in pull request #14006:
URL: https://github.com/apache/airflow/pull/14006#discussion_r569005840



##########
File path: airflow/providers/amazon/aws/utils/emailer.py
##########
@@ -31,7 +31,7 @@ def send_email(
     bcc: Optional[Union[List[str], str]] = None,
     mime_subtype: str = 'mixed',
     mime_charset: str = 'utf-8',
-    conn_id: Optional[str] = None,
+    conn_id: str = 'ses_default',

Review comment:
       All AWS integration should share common conn_id. See: https://github.com/apache/airflow/blob/master/UPDATING.md#normalize-gcp_conn_id-for-google-cloud
   If the user needs it, he can define more complex configurations, but the default should assume that all AWS / GCP services have one credential.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org