You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/29 02:06:51 UTC
[GitHub] [apisix] SylviaBABY opened a new pull request, #8580: docs: update Contributing details about gifts part
SylviaBABY opened a new pull request, #8580:
URL: https://github.com/apache/apisix/pull/8580
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Because the content is a bit outdated, some details need to be updated.
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] EmilyKeer commented on a diff in pull request #8580: docs: update Contributing details about gifts part
Posted by GitBox <gi...@apache.org>.
EmilyKeer commented on code in PR #8580:
URL: https://github.com/apache/apisix/pull/8580#discussion_r1058700162
##########
CONTRIBUTING.md:
##########
@@ -141,11 +138,13 @@ Once we've discussed your changes and you've got your code ready, make sure that
Please take a look at `t/plugin/limit-conn.t` and `t/plugin/limit-conn2.t`.
* For more details, see the [testing framework](https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md)
-## Contributor T-shirt
+## Contributor gifts
-If you have contributed to Apache APISIX, no matter it is a code contribution to fix a bug or a feature request, or a documentation change, Congratulations! You are eligible to receive the very special Contributor T-shirt! It's always been the community effort that has made Apache APISIX be understood and used by more developers. Go ahead and fill out the [Contributors Submissions form](https://docs.google.com/forms/d/e/1FAIpQLSdXEpCs60UK49UlOGdBCQSXr7DYz3enyT4GJPKrYQmYfVLPKQ/viewform).
+If you have contributed to Apache APISIX, no matter it is a code contribution to fix a bug or a feature request, or a documentation change, Congratulations! You are eligible to receive the APISIX special gifts with electronic certificate! It's always been the community effort that has made Apache APISIX be understood and used by more developers.
Review Comment:
```suggestion
If you have contributed to Apache APISIX, no matter it is a code contribution to fix a bug or a feature request, or a documentation change, Congratulations! You are eligible to receive the APISIX special gifts with a digital certificate! It's always been the community effort that has made Apache APISIX be understood and used by more developers.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #8580: docs: update Contributing details about gifts part
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #8580:
URL: https://github.com/apache/apisix/pull/8580#discussion_r1058752270
##########
CONTRIBUTING.md:
##########
@@ -141,11 +138,13 @@ Once we've discussed your changes and you've got your code ready, make sure that
Please take a look at `t/plugin/limit-conn.t` and `t/plugin/limit-conn2.t`.
* For more details, see the [testing framework](https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md)
-## Contributor T-shirt
+## Contributor gifts
-If you have contributed to Apache APISIX, no matter it is a code contribution to fix a bug or a feature request, or a documentation change, Congratulations! You are eligible to receive the very special Contributor T-shirt! It's always been the community effort that has made Apache APISIX be understood and used by more developers. Go ahead and fill out the [Contributors Submissions form](https://docs.google.com/forms/d/e/1FAIpQLSdXEpCs60UK49UlOGdBCQSXr7DYz3enyT4GJPKrYQmYfVLPKQ/viewform).
+If you have contributed to Apache APISIX, no matter it is a code contribution to fix a bug or a feature request, or a documentation change, Congratulations! You are eligible to receive the APISIX special gifts with a digital certificate! It's always been the community effort that has made Apache APISIX be understood and used by more developers.
-
+
+
+If you are a **contributor in China**, you can [click this link](https://wj.qq.com/s2/11438041/7b07/) to supplement relevant information; If you are a **contributor outside of China**, you can click this [Google form](https://forms.gle/DhPL96LnJwuaHjHU7) to supplement relevant information. After filling in the form, please wait patiently. The community will handle it as soon as possible after receiving the information.
Review Comment:
cc @SylviaBABY @EmilyKeer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY merged pull request #8580: docs: update Contributing details about gifts part
Posted by GitBox <gi...@apache.org>.
SylviaBABY merged PR #8580:
URL: https://github.com/apache/apisix/pull/8580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #8580: docs: update Contributing details about gifts part
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #8580:
URL: https://github.com/apache/apisix/pull/8580#discussion_r1058752212
##########
CONTRIBUTING.md:
##########
@@ -141,11 +138,13 @@ Once we've discussed your changes and you've got your code ready, make sure that
Please take a look at `t/plugin/limit-conn.t` and `t/plugin/limit-conn2.t`.
* For more details, see the [testing framework](https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md)
-## Contributor T-shirt
+## Contributor gifts
-If you have contributed to Apache APISIX, no matter it is a code contribution to fix a bug or a feature request, or a documentation change, Congratulations! You are eligible to receive the very special Contributor T-shirt! It's always been the community effort that has made Apache APISIX be understood and used by more developers. Go ahead and fill out the [Contributors Submissions form](https://docs.google.com/forms/d/e/1FAIpQLSdXEpCs60UK49UlOGdBCQSXr7DYz3enyT4GJPKrYQmYfVLPKQ/viewform).
+If you have contributed to Apache APISIX, no matter it is a code contribution to fix a bug or a feature request, or a documentation change, Congratulations! You are eligible to receive the APISIX special gifts with a digital certificate! It's always been the community effort that has made Apache APISIX be understood and used by more developers.
-
+
+
+If you are a **contributor in China**, you can [click this link](https://wj.qq.com/s2/11438041/7b07/) to supplement relevant information; If you are a **contributor outside of China**, you can click this [Google form](https://forms.gle/DhPL96LnJwuaHjHU7) to supplement relevant information. After filling in the form, please wait patiently. The community will handle it as soon as possible after receiving the information.
Review Comment:
```suggestion
Contributors can request gifts by filling out this [Google form](https://forms.gle/DhPL96LnJwuaHjHU7) or [QQ Form](https://wj.qq.com/s2/11438041/7b07/). After filling in the form, please wait patiently. The community needs some time to review submissions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org