You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "nfx (via GitHub)" <gi...@apache.org> on 2023/05/02 08:13:50 UTC

[GitHub] [spark] nfx commented on a diff in pull request #40993: Make it possible to extend `ChannelBuilder` for `SparkConnectClient`

nfx commented on code in PR #40993:
URL: https://github.com/apache/spark/pull/40993#discussion_r1182227217


##########
python/pyspark/sql/connect/client.py:
##########
@@ -523,17 +523,22 @@ def __init__(
 
         Parameters
         ----------
-        connectionString: Optional[str]
+        connection: Optional[Union[str,ChannelBuilder]]

Review Comment:
   will change, was following the semantics of the previous signature



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org