You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/14 09:33:33 UTC
[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
cxzl25 opened a new pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553
### _Why are the changes needed?_
Compatible with lower version of hive driver.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#issuecomment-993440179
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1553](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25300d5) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/3594e08d1be1e657bdb6c6a7f45862c2879b57a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3594e08) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head 25300d5 differs from pull request most recent head 908c475. Consider uploading reports for the commit 908c475 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
=========================================
Coverage 59.28% 59.28%
Complexity 172 172
=========================================
Files 241 241
Lines 12224 12224
Branches 1501 1501
=========================================
Hits 7247 7247
Misses 4364 4364
Partials 613 613
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3594e08...908c475](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#discussion_r768478374
##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -146,5 +146,5 @@ object HighAvailabilityConf {
.doc("Whether we should publish Kerberos configs to ZooKeeper.")
.version("1.4.0")
.booleanConf
- .createWithDefault(UserGroupInformation.isSecurityEnabled)
Review comment:
can you fix a typo in the name `PUBLIST` -> `PUBLISH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#issuecomment-993348536
https://github.com/apache/incubator-kyuubi/pull/1175#issuecomment-993263295
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#issuecomment-993440179
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1553](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (908c475) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/3594e08d1be1e657bdb6c6a7f45862c2879b57a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3594e08) will **decrease** coverage by `0.56%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 908c475 differs from pull request most recent head 39cbdf4. Consider uploading reports for the commit 39cbdf4 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
============================================
- Coverage 59.28% 58.71% -0.57%
- Complexity 172 248 +76
============================================
Files 241 258 +17
Lines 12224 12827 +603
Branches 1501 1574 +73
============================================
+ Hits 7247 7532 +285
- Misses 4364 4657 +293
- Partials 613 638 +25
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...i/ha/client/zookeeper/ServiceDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvU2VydmljZURpc2NvdmVyeUNsaWVudC5zY2FsYQ==) | `46.07% <0.00%> (ø)` | |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <100.00%> (ø)` | |
| [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `89.47% <0.00%> (-3.51%)` | :arrow_down: |
| [...g/apache/kyuubi/engine/flink/result/ResultSet.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9SZXN1bHRTZXQuamF2YQ==) | `47.72% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/flink/result/Constants.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/kyuubi/engine/flink/context/EngineContext.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbnRleHQvRW5naW5lQ29udGV4dC5qYXZh) | `43.47% <0.00%> (ø)` | |
| [...org/apache/kyuubi/engine/flink/schema/RowSet.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9zY2hlbWEvUm93U2V0LnNjYWxh) | `11.36% <0.00%> (ø)` | |
| [.../kyuubi/engine/flink/context/ExecutionContext.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbnRleHQvRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `82.71% <0.00%> (ø)` | |
| [...yuubi/engine/flink/config/entries/ConfigEntry.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbmZpZy9lbnRyaWVzL0NvbmZpZ0VudHJ5LmphdmE=) | `40.00% <0.00%> (ø)` | |
| [...bi/engine/flink/config/entries/ExecutionEntry.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbmZpZy9lbnRyaWVzL0V4ZWN1dGlvbkVudHJ5LmphdmE=) | `58.59% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3594e08...39cbdf4](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#issuecomment-993697400
Thanks, merging to master/1.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#issuecomment-993440179
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1553](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39cbdf4) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/3594e08d1be1e657bdb6c6a7f45862c2879b57a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3594e08) will **decrease** coverage by `0.22%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
============================================
- Coverage 59.28% 59.06% -0.23%
- Complexity 172 248 +76
============================================
Files 241 260 +19
Lines 12224 12969 +745
Branches 1501 1621 +120
============================================
+ Hits 7247 7660 +413
- Misses 4364 4663 +299
- Partials 613 646 +33
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...i/ha/client/zookeeper/ServiceDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvU2VydmljZURpc2NvdmVyeUNsaWVudC5zY2FsYQ==) | `46.07% <0.00%> (ø)` | |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <100.00%> (ø)` | |
| [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `89.47% <0.00%> (-3.51%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/util/RowSetUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS91dGlsL1Jvd1NldFV0aWxzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [.../kyuubi/engine/flink/config/EngineEnvironment.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbmZpZy9FbmdpbmVFbnZpcm9ubWVudC5qYXZh) | `66.66% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/flink/result/Constants.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ache/kyuubi/engine/flink/result/OperationUtil.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9PcGVyYXRpb25VdGlsLmphdmE=) | `80.00% <0.00%> (ø)` | |
| [...yuubi/engine/flink/config/entries/ConfigEntry.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbmZpZy9lbnRyaWVzL0NvbmZpZ0VudHJ5LmphdmE=) | `40.00% <0.00%> (ø)` | |
| [.../apache/kyuubi/engine/flink/result/ColumnInfo.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db2x1bW5JbmZvLmphdmE=) | `38.88% <0.00%> (ø)` | |
| [...he/kyuubi/engine/flink/operation/GetCatalogs.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9vcGVyYXRpb24vR2V0Q2F0YWxvZ3Muc2NhbGE=) | `87.50% <0.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3594e08...39cbdf4](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#discussion_r768478608
##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala
##########
@@ -146,5 +146,5 @@ object HighAvailabilityConf {
.doc("Whether we should publish Kerberos configs to ZooKeeper.")
Review comment:
Can we add some description of HIVE-11581? e.g. the minimal compatible version of hive client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1553: [KYUUBI #1174][FOLLOWUP] change configuration(ha.zookeeper.publish.configs) default value to false
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1553:
URL: https://github.com/apache/incubator-kyuubi/pull/1553#issuecomment-993440179
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1553](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2f9072) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/3594e08d1be1e657bdb6c6a7f45862c2879b57a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3594e08) will **decrease** coverage by `0.56%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head b2f9072 differs from pull request most recent head 908c475. Consider uploading reports for the commit 908c475 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1553 +/- ##
============================================
- Coverage 59.28% 58.71% -0.57%
- Complexity 172 248 +76
============================================
Files 241 258 +17
Lines 12224 12827 +603
Branches 1501 1574 +73
============================================
+ Hits 7247 7532 +285
- Misses 4364 4657 +293
- Partials 613 638 +25
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...i/ha/client/zookeeper/ServiceDiscoveryClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvU2VydmljZURpc2NvdmVyeUNsaWVudC5zY2FsYQ==) | `46.07% <0.00%> (ø)` | |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <100.00%> (ø)` | |
| [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `89.47% <0.00%> (-3.51%)` | :arrow_down: |
| [.../kyuubi/engine/flink/config/EngineEnvironment.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbmZpZy9FbmdpbmVFbnZpcm9ubWVudC5qYXZh) | `66.66% <0.00%> (ø)` | |
| [.../apache/kyuubi/engine/flink/result/ColumnInfo.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db2x1bW5JbmZvLmphdmE=) | `38.88% <0.00%> (ø)` | |
| [...kyuubi/engine/flink/session/FlinkSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9zZXNzaW9uL0ZsaW5rU2Vzc2lvbkltcGwuc2NhbGE=) | `100.00% <0.00%> (ø)` | |
| [...kyuubi/engine/flink/operation/FlinkOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9vcGVyYXRpb24vRmxpbmtPcGVyYXRpb24uc2NhbGE=) | `39.28% <0.00%> (ø)` | |
| [...he/kyuubi/engine/flink/context/SessionContext.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL2NvbnRleHQvU2Vzc2lvbkNvbnRleHQuamF2YQ==) | `61.90% <0.00%> (ø)` | |
| [.../apache/kyuubi/engine/flink/result/ResultKind.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9SZXN1bHRLaW5kLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/flink/result/ResultSet.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9SZXN1bHRTZXQuamF2YQ==) | `47.72% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3594e08...908c475](https://codecov.io/gh/apache/incubator-kyuubi/pull/1553?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org