You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/09 03:53:56 UTC

[GitHub] [flink] wenlong88 opened a new pull request #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

wenlong88 opened a new pull request #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679
 
 
   ## What is the purpose of the change
   This pr adds an IdleTime metric which measures idle time of a task including the time cost for mail processor to wait for new mail and the time cost in record writer to waiting a new buffer.
   1. when a job can not catch up with the speed of data generating, the vertex which idle time is near to zero is the bottle neck of the job.
   2. when a job is not busy, idle time can be used to guide user how much he can scale down the job.
   
   ## Brief change log
   A meter metrics named idleTimeMsPerSecond is added in TaskIOMetricGroup:
     - *idleTime contains time waiting mail and time waiting output buffer. *
     - *waiting mail time is collected when mail processor is trying to process a new mail but no mail submitted.*
     - *waiting output buffer time is collected when record writer is trying to request a new buffer from result partition but no buffer available.* 
   
   in addition to https://github.com/apache/flink/pull/11564 to fix unstable test in https://issues.apache.org/jira/browse/FLINK-17053 and https://issues.apache.org/jira/browse/FLINK-17054:
   - testClearBuffersAfterInterruptDuringBlockingBufferRequest is refactored so that it is not depends Mock Class.
   - only check valid idle time collected(idleTime > 0) in ut instead of exactly idle time to avoid race condition affects result of test.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
     - *TaskIOMetricGroupTest*
     - *RecordWriterTest*
     - *TaskMailboxProcessorTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159527732",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159538950",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5ee392b49a859ba781cd202e41eb8ed6f6e91eec Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159538950) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159527732",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9cd7e32a68f82470bc05735009c1c0377d066d44 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159527732) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611314262
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9cd7e32a68f82470bc05735009c1c0377d066d44 (Thu Apr 09 03:57:00 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9cd7e32a68f82470bc05735009c1c0377d066d44 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159527732",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9cd7e32a68f82470bc05735009c1c0377d066d44 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159527732) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254) 
   * 5ee392b49a859ba781cd202e41eb8ed6f6e91eec UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159527732",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9cd7e32a68f82470bc05735009c1c0377d066d44 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159527732) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159527732",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159538950",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9cd7e32a68f82470bc05735009c1c0377d066d44 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159527732) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254) 
   * 5ee392b49a859ba781cd202e41eb8ed6f6e91eec Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159538950) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159527732",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159538950",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5ee392b49a859ba781cd202e41eb8ed6f6e91eec Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159538950) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski merged pull request #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611341172
 
 
   Thanks for the quick fix @wenlong88. Let's wait for the Azure/Travis to complete. Also before merging we should squash those two commits together. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611318400
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159527732",
       "triggerID" : "9cd7e32a68f82470bc05735009c1c0377d066d44",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159538950",
       "triggerID" : "5ee392b49a859ba781cd202e41eb8ed6f6e91eec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9cd7e32a68f82470bc05735009c1c0377d066d44 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159527732) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7254) 
   * 5ee392b49a859ba781cd202e41eb8ed6f6e91eec Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159538950) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7258) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wenlong88 commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.

Posted by GitBox <gi...@apache.org>.
wenlong88 commented on issue #11679: [FLINK-16864][metrics] Add IdleTime metric for task.
URL: https://github.com/apache/flink/pull/11679#issuecomment-611357905
 
 
   @pnowojski  thanks for reviewing again. Tests on Travis have passed, so I merged the two commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services