You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/20 01:18:50 UTC

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5872: Fix enroller build error due to out-of-scope ARG

zrhoffman commented on a change in pull request #5872:
URL: https://github.com/apache/trafficcontrol/pull/5872#discussion_r635681929



##########
File path: infrastructure/cdn-in-a-box/enroller/Dockerfile
##########
@@ -43,7 +43,7 @@ COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_o
 COPY ./infrastructure/cdn-in-a-box/ /go/src/github.com/apache/trafficcontrol/infrastructure/cdn-in-a-box/
 
 WORKDIR /go/src/github.com/apache/trafficcontrol/infrastructure/cdn-in-a-box/enroller
-RUN set -o errexit -o nounset; \
+RUN set -o errexit; \

Review comment:
       We shouldn't remove `-o nounset`, though, since it found an error. We just need to move the definition for the build arg that is not properly defined.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org