You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "Hyunsik Choi (JIRA)" <ji...@apache.org> on 2014/07/15 04:16:05 UTC

[jira] [Created] (TAJO-940) Default null config for CSV file in StoreTableExec should be moved to planning phase.

Hyunsik Choi created TAJO-940:
---------------------------------

             Summary: Default null config for CSV file in StoreTableExec should be moved to planning phase.
                 Key: TAJO-940
                 URL: https://issues.apache.org/jira/browse/TAJO-940
             Project: Tajo
          Issue Type: Improvement
            Reporter: Hyunsik Choi
            Priority: Minor
             Fix For: 0.9.0


For more clear code, the null config should be moved to the planning phase.

{code:title="StoreTableExec.java"}
 if (plan instanceof InsertNode) {
      InsertNode createTableNode = (InsertNode) plan;
      appender = StorageManagerFactory.getStorageManager(context.getConf()).getAppender(meta,
          createTableNode.getTableSchema(), lastFileName);
    } else {
      String nullChar = context.getQueryContext().get(ConfVars.CSVFILE_NULL.varname, ConfVars.CSVFILE_NULL.defaultVal);
      meta.putOption(StorageConstants.CSVFILE_NULL, nullChar);
      appender = StorageManagerFactory.getStorageManager(context.getConf()).getAppender(meta, outSchema,
          lastFileName);
    }
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)