You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/25 08:27:48 UTC
[GitHub] [hudi] wangxianghu opened a new pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
wangxianghu opened a new pull request #2033:
URL: https://github.com/apache/hudi/pull/2033
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Introduce MergeHelper.UpdateHandler as independent class*
## Brief change log
Making UpdateHandler class independent helps reduce the workload of refactoring hudi-client
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-679987475
> for such a helper struct like class, it makes sense to be inline right? can you please help me understand the reason behind this refactor.
@vinothchandar thanks for the reply
This is prepared for the multi-engine support abstraction. In the abstraction, MergerHelper can be abstract to an abstract class, its inner class UpdateHandler referenced HoodieMergeHandle, which is related to spark. so I think maybe we can make it an independent class, convenient to expand.
Doing these little adjusts before rebase(or refactor) can reduce the review work of HUDI-1089, that`s my thought, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-679927856
@yanghua please take a look when free
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-684886431
that refactor is going to be huge anyway. if you are making code changes and moving the files around, its better to do in a separate PR. otherwise, if its all file moves. we can do it in one pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-679965694
for such a helper struct like class, it makes sense to be inline right? can you please help me understand the reason behind this refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu closed pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #2033:
URL: https://github.com/apache/hudi/pull/2033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-685447284
> that refactor is going to be huge anyway. if you are making code changes and moving the files around, its better to do in a separate PR. otherwise, if its all file moves. we can do it in one pr
not too many files to move, and I finally think out a way to do the refactor without moving the inner class.
If there is a need in the future, I will file a separate PR.
thanks for reply :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2033: [HUDI-1222] Introduce MergeHelper.UpdateHandler as independent class
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2033:
URL: https://github.com/apache/hudi/pull/2033#issuecomment-682303627
let`s keep it in HUDI-1089
closing now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org