You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2012/06/08 17:18:22 UTC
[jira] [Created] (LUCENE-4121) Standardize
ramBytesUsed/sizeInBytes/memSize
Adrien Grand created LUCENE-4121:
------------------------------------
Summary: Standardize ramBytesUsed/sizeInBytes/memSize
Key: LUCENE-4121
URL: https://issues.apache.org/jira/browse/LUCENE-4121
Project: Lucene - Java
Issue Type: Task
Reporter: Adrien Grand
Assignee: Adrien Grand
Priority: Minor
Fix For: 5.0
We should standardize the names of the methods we use to estimate the sizes of objects in memory and on disk. (cf. discussion on dev@lucene http://search-lucene.com/m/VbXSx1BP60G).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4121) Standardize
ramBytesUsed/sizeInBytes/memSize
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand updated LUCENE-4121:
---------------------------------
Attachment: LUCENE-4121.patch
First version of the patch.
I first tried to replace the size methods by either {{memSize}} or {{diskSize}} depending on what they measured. But I was not happy with the fact that some {{diskSize}} methods might actually measure in-memory sizes when the underlying directory implementation is a {{RAMDirectory}}. So I ended up with 3 method names:
* memSize, for in-memory usage,
* diskSize, for on-disk size (hybrid data structures may implement both methods),
* byteSize for abstract types ({{SegmentInfo}}, {{MergePolicy}}, ...). In that case, the {{byteSize}} may actually be a {{memSize}} or a {{diskSize}} depending on the directory implementation.
Or maybe we could still use {{diskSize}}, RAMDirectory being a special case. {{diskSize}} would even make sense for {{CachingRAMDirectory}} actually.
> Standardize ramBytesUsed/sizeInBytes/memSize
> --------------------------------------------
>
> Key: LUCENE-4121
> URL: https://issues.apache.org/jira/browse/LUCENE-4121
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4121.patch
>
>
> We should standardize the names of the methods we use to estimate the sizes of objects in memory and on disk. (cf. discussion on dev@lucene http://search-lucene.com/m/VbXSx1BP60G).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4121) Standardize
ramBytesUsed/sizeInBytes/memSize
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291831#comment-13291831 ]
Simon Willnauer commented on LUCENE-4121:
-----------------------------------------
Adrien I think we can do that for 4.0 too though
> Standardize ramBytesUsed/sizeInBytes/memSize
> --------------------------------------------
>
> Key: LUCENE-4121
> URL: https://issues.apache.org/jira/browse/LUCENE-4121
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 5.0
>
>
> We should standardize the names of the methods we use to estimate the sizes of objects in memory and on disk. (cf. discussion on dev@lucene http://search-lucene.com/m/VbXSx1BP60G).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4121) Standardize
ramBytesUsed/sizeInBytes/memSize
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand updated LUCENE-4121:
---------------------------------
Fix Version/s: 4.0
> Standardize ramBytesUsed/sizeInBytes/memSize
> --------------------------------------------
>
> Key: LUCENE-4121
> URL: https://issues.apache.org/jira/browse/LUCENE-4121
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.0, 5.0
>
>
> We should standardize the names of the methods we use to estimate the sizes of objects in memory and on disk. (cf. discussion on dev@lucene http://search-lucene.com/m/VbXSx1BP60G).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4121) Standardize
ramBytesUsed/sizeInBytes/memSize
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291834#comment-13291834 ]
Adrien Grand commented on LUCENE-4121:
--------------------------------------
Updated fix version.
> Standardize ramBytesUsed/sizeInBytes/memSize
> --------------------------------------------
>
> Key: LUCENE-4121
> URL: https://issues.apache.org/jira/browse/LUCENE-4121
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.0, 5.0
>
>
> We should standardize the names of the methods we use to estimate the sizes of objects in memory and on disk. (cf. discussion on dev@lucene http://search-lucene.com/m/VbXSx1BP60G).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4121) Standardize
ramBytesUsed/sizeInBytes/memSize
Posted by "Adrien Grand (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291819#comment-13291819 ]
Adrien Grand commented on LUCENE-4121:
--------------------------------------
I am currently thinking of {{memSize}} for the in-memory size and {{diskSize}} for the on-disk size.
> Standardize ramBytesUsed/sizeInBytes/memSize
> --------------------------------------------
>
> Key: LUCENE-4121
> URL: https://issues.apache.org/jira/browse/LUCENE-4121
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 5.0
>
>
> We should standardize the names of the methods we use to estimate the sizes of objects in memory and on disk. (cf. discussion on dev@lucene http://search-lucene.com/m/VbXSx1BP60G).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org