You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by gr...@apache.org on 2009/05/07 08:41:43 UTC

svn commit: r772516 - /incubator/log4php/trunk/src/main/php/layouts/LoggerPatternLayout.php

Author: grobmeier
Date: Thu May  7 06:41:41 2009
New Revision: 772516

URL: http://svn.apache.org/viewvc?rev=772516&view=rev
Log:
removed unnecessary factory in favor of direct instanciation

Modified:
    incubator/log4php/trunk/src/main/php/layouts/LoggerPatternLayout.php

Modified: incubator/log4php/trunk/src/main/php/layouts/LoggerPatternLayout.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/layouts/LoggerPatternLayout.php?rev=772516&r1=772515&r2=772516&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/layouts/LoggerPatternLayout.php (original)
+++ incubator/log4php/trunk/src/main/php/layouts/LoggerPatternLayout.php Thu May  7 06:41:41 2009
@@ -189,7 +189,7 @@
     function setConversionPattern($conversionPattern)
     {
         $this->pattern = $conversionPattern;
-        $patternParser = $this->createPatternParser($this->pattern);
+        $patternParser = new LoggerPatternParser($this->pattern);
         $this->head = $patternParser->parse();
     }
     
@@ -207,19 +207,6 @@
     }
     
     /**
-     * Returns LoggerPatternParser used to parse the conversion string. Subclasses
-     * may override this to return a subclass of PatternParser which recognize
-     * custom conversion characters.
-     *
-     * @param string $pattern
-     * @return LoggerPatternParser
-     */
-    function createPatternParser($pattern)
-    {
-        return new LoggerPatternParser($pattern);
-    }
-    
-    /**
      * Produces a formatted string as specified by the conversion pattern.
      *
      * @param LoggerLoggingEvent $event