You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Matthias Pohl (Jira)" <ji...@apache.org> on 2022/10/28 05:43:00 UTC

[jira] [Resolved] (FLINK-26390) InputStream is not closed at CliClient#executeFile

     [ https://issues.apache.org/jira/browse/FLINK-26390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Pohl resolved FLINK-26390.
-----------------------------------
    Resolution: Fixed

master: 74c0ace01b61f18cda5c13abf0b940fe81f13e8a

> InputStream is not closed at CliClient#executeFile
> --------------------------------------------------
>
>                 Key: FLINK-26390
>                 URL: https://issues.apache.org/jira/browse/FLINK-26390
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Table SQL / Client
>    Affects Versions: 1.15.0
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Minor
>              Labels: auto-deprioritized-major, pull-request-available
>
> There is {{InputStream}} created however not closed
> https://github.com/apache/flink/blob/e2463ddace26601c6442dbaa68c198a27c9cfbcf/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java#L349-L364
> Another thing, which is easy to fix: it seems there is no need to create completer object for {{CliClient#executeFile}} since it makes sense only in interactive mode 
> It seems the reason is https://github.com/apache/flink/pull/18363/files



--
This message was sent by Atlassian Jira
(v8.20.10#820010)