You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 00:35:38 UTC

[GitHub] [spark] BryanCutler commented on pull request #28793: [SPARK-31964][PYTHON] Use Pandas is_categorical on Arrow category type conversion

BryanCutler commented on pull request #28793:
URL: https://github.com/apache/spark/pull/28793#issuecomment-642337309


   @HyukjinKwon I though we could avoid any categorical imports by comparing the dtype with strings, e.g. `s.dtype == 'category'` but that seems to fail for any other types than categories. It seems `is_categorical` is the preferred stable api. This change is not that different from what is there currently, so not a big deal if you think this isn't better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org