You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 19:20:03 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #28838: Validate Sphinx Inventory file header
Taragolis opened a new pull request, #28838:
URL: https://github.com/apache/airflow/pull/28838
follow-up: https://github.com/apache/airflow/pull/28834
1. Before save inventory file validate headers
2. Stop processing if any error happen during fetching inventory, it could save additional 20-40 minute because without inventories most probably documentation build would fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #28838: Validate Sphinx Inventory file header
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #28838:
URL: https://github.com/apache/airflow/pull/28838#discussion_r1066360473
##########
docs/exts/docs_build/fetch_inventories.py:
##########
@@ -47,25 +49,41 @@
def _fetch_file(session: requests.Session, package_name: str, url: str, path: str) -> tuple[str, bool]:
"""
- Download a file and returns status information as a tuple with package
+ Download a file, validate Sphinx Inventory headers and returns status information as a tuple with package
name and success status(bool value).
"""
try:
response = session.get(url, allow_redirects=True, stream=True)
except (requests.RequestException, urllib3.exceptions.HTTPError):
- print(f"Failed to fetch inventory: {url}")
+ print(f"{package_name}: Failed to fetch inventory: {url}")
traceback.print_exc(file=sys.stderr)
return package_name, False
if not response.ok:
- print(f"Failed to fetch inventory: {url}")
- print(f"Failed with status: {response.status_code}", file=sys.stderr)
+ print(f"{package_name}: Failed to fetch inventory: {url}")
+ print(f"{package_name}: Failed with status: {response.status_code}", file=sys.stderr)
return package_name, False
- os.makedirs(os.path.dirname(path), exist_ok=True)
- with open(path, "wb") as f:
- response.raw.decode_content = True
- shutil.copyfileobj(response.raw, f)
- print(f"Fetched inventory: {url}")
+ if response.url != url:
+ print(f"{package_name}: {url} redirected to {response.url}")
Review Comment:
NICE!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28838: Validate Sphinx Inventory file header
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28838:
URL: https://github.com/apache/airflow/pull/28838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org