You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by sudheeshkatkam <gi...@git.apache.org> on 2015/07/08 19:04:13 UTC
[GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
GitHub user sudheeshkatkam opened a pull request:
https://github.com/apache/drill/pull/80
DRILL-2650: Mark query end time when closing the Foreman
@jacques-n @cwestin please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sudheeshkatkam/drill DRILL-2650
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit 1ad9c5ad8d70947f029132ff1abfd03d02f464c0
Author: Sudheesh Katkam <sk...@maprtech.com>
Date: 2015-07-07T21:08:09Z
DRILL-2650: Mark query end time when closing the Foreman
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/80#issuecomment-123918414
Downgraded to .debug()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
Posted by cwestin <gi...@git.apache.org>.
Github user cwestin commented on a diff in the pull request:
https://github.com/apache/drill/pull/80#discussion_r34406523
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -789,7 +794,7 @@ protected void processEvent(final StateEvent event) {
final Exception exception = event.exception;
// TODO Auto-generated method stub
- logger.info("State change requested. {} --> {}", state, newState,
+ logger.info(queryIdString + ": State change requested {} --> {}", state, newState,
--- End diff --
.info() -> .debug()?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
Posted by cwestin <gi...@git.apache.org>.
Github user cwestin commented on a diff in the pull request:
https://github.com/apache/drill/pull/80#discussion_r34406507
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -695,7 +697,10 @@ public void close() {
Preconditions.checkState(!isClosed);
Preconditions.checkState(resultState != null);
- logger.info("foreman cleaning up.");
+ // to track how long the query takes
+ queryManager.markEndTime();
+
+ logger.info(queryIdString + ": cleaning up.");
--- End diff --
.info() seems like it will generate a lot of noise here, should it be .debug()?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/80#issuecomment-138727479
+1, LGTM
It's important to note this won't fix the running time for failed queries, at least not until DRILL-3167 is fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2650: Mark query end time when closing t...
Posted by cwestin <gi...@git.apache.org>.
Github user cwestin commented on the pull request:
https://github.com/apache/drill/pull/80#issuecomment-120554910
Do we want to stick with .info() for these messages instead of .debug()? Asking because I'm not sure, but it seems like noise.
Otherwise, non-binding "ship it."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---