You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/04/28 22:54:54 UTC
[Impala-ASF-CR] IMPALA-9627 (followup): Switch push to asf.py to python 3
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19817
Change subject: IMPALA-9627 (followup): Switch push_to_asf.py to python 3
......................................................................
IMPALA-9627 (followup): Switch push_to_asf.py to python 3
push_to_asf.py asks the user for input. This recently
switched from raw_input() to input(), because Python 3
doesn't have a raw_input() function.
Python 2's input() function has weird semantics. At the
"[Y/n]:" prompt, typing y (no quotes) produces this error:
NameError: name 'y' is not defined
Instead, it wants 'y' (with quotes). This is because Python 2's
input() function wants a python expression. This switches the
script to use python3, which has the old behavior from
raw_input().
Testing:
- Ran script with Python 3, hand tested the confirm_prompt function
Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
---
M bin/push_to_asf.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/19817/1
--
To view, visit http://gerrit.cloudera.org:8080/19817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627 (followup): Switch push to asf.py to python 3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19817 )
Change subject: IMPALA-9627 (followup): Switch push_to_asf.py to python 3
......................................................................
Patch Set 2:
> This fails check-python-syntax.sh. I'll look at having it skip
> files with python3 in the first line.
Sorry, we can revert in the meantime to unblock others.
--
To view, visit http://gerrit.cloudera.org:8080/19817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 20:23:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Switch push to asf.py to python 3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19817 )
Change subject: IMPALA-9627 (followup): Switch push_to_asf.py to python 3
......................................................................
Patch Set 1: Verified+1
GVO doesn't cover this script, so going ahead. I have used this version of script to push commits to master.
--
To view, visit http://gerrit.cloudera.org:8080/19817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 21:50:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Switch push to asf.py to python 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19817 )
Change subject: IMPALA-9627 (followup): Switch push_to_asf.py to python 3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12894/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 23:15:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Switch push to asf.py to python 3
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19817 )
Change subject: IMPALA-9627 (followup): Switch push_to_asf.py to python 3
......................................................................
IMPALA-9627 (followup): Switch push_to_asf.py to python 3
push_to_asf.py asks the user for input. This recently
switched from raw_input() to input(), because Python 3
doesn't have a raw_input() function.
Python 2's input() function has weird semantics. At the
"[Y/n]:" prompt, typing y (no quotes) produces this error:
NameError: name 'y' is not defined
Instead, it wants 'y' (with quotes). This is because Python 2's
input() function wants a python expression. This switches the
script to use python3, which has the old behavior from
raw_input().
Testing:
- Ran script with Python 3, hand tested the confirm_prompt function
Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Reviewed-on: http://gerrit.cloudera.org:8080/19817
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/push_to_asf.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9627 (followup): Switch push to asf.py to python 3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19817 )
Change subject: IMPALA-9627 (followup): Switch push_to_asf.py to python 3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 17:27:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9627 (followup): Switch push to asf.py to python 3
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19817 )
Change subject: IMPALA-9627 (followup): Switch push_to_asf.py to python 3
......................................................................
Patch Set 2:
This fails check-python-syntax.sh. I'll look at having it skip files with python3 in the first line.
--
To view, visit http://gerrit.cloudera.org:8080/19817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida49993bfea71ade9d335ac1ceb53788d0a57f69
Gerrit-Change-Number: 19817
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 May 2023 20:18:51 +0000
Gerrit-HasComments: No