zeppelin git commit: [ZEPPELIN-2291] Notebook commit dropdown cut-off

[mo...@apache.org]

Repository: zeppelin
Updated Branches:
  refs/heads/master f76ac8807 -> 58189ec89


[ZEPPELIN-2291] Notebook commit dropdown cut-off

### What is this PR for?
When you have a notebook under GIT version control, the dropdown with your commits will be cut-off with no possibility to scroll to older commits (see attached screenshot).

This fixes it by applying a relative max-height and appropriate overflow (similar styles as for the notebooks dropdown in the navigation bar). If the dropdown is longer than max-height, a scrollbar will be shown :)

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2291

### How should this be tested?
Create a notebook under version control and make a couple of changes & commits, until the dropdown gets too long to fit on one screen. If everything works as intended, you should now be able to scroll to older commits inside the dropdown.

### Screenshots (if appropriate)
![apache_zeppelin_commit_dropdown_cut_off](https://cloud.githubusercontent.com/assets/1144202/24155455/3041dcfc-0e54-11e7-8120-3617d579f29f.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Alexander Wenzel <we...@myhammer.de>

Closes #2173 from elkangaroo/ZEPPELIN-2291-Commit-Dropdown-Scroll and squashes the following commits:

110df35 [Alexander Wenzel] [ZEPPELIN-2291] Fix cut-off revision dropdown


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/58189ec8
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/58189ec8
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/58189ec8

Branch: refs/heads/master
Commit: 58189ec89c2c2ce83ccc0a1ba3b5c5372bc5cded
Parents: f76ac88
Author: Alexander Wenzel <we...@myhammer.de>
Authored: Tue Mar 21 16:30:09 2017 +0100
Committer: Lee moon soo <mo...@apache.org>
Committed: Fri Mar 24 14:08:28 2017 -0700

----------------------------------------------------------------------
 zeppelin-web/src/app/home/home.css             | 13 ++++++++++++-
 zeppelin-web/src/components/navbar/navbar.html |  2 +-
 2 files changed, 13 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/58189ec8/zeppelin-web/src/app/home/home.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/home/home.css b/zeppelin-web/src/app/home/home.css
index f813ccc..c670f6b 100644
--- a/zeppelin-web/src/app/home/home.css
+++ b/zeppelin-web/src/app/home/home.css
@@ -298,10 +298,21 @@ a.navbar-brand:hover {
 }
 
 @media (min-width: 768px) {
-  .dropdown-menu.navbar-dropdown-maxHeight {
+  .navbar-fixed-top .dropdown-menu {
     max-height: calc(100vh - 60px);
     overflow: auto;
   }
+  #actionbar .dropdown-menu {
+    max-height: calc(100vh - 110px);
+    overflow: auto;
+  }
+}
+
+@media (max-width: 767px) {
+  #actionbar .dropdown-menu {
+    max-height: calc(100vh - 160px);
+    overflow: auto;
+  }
 }
 
 .nav-component {

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/58189ec8/zeppelin-web/src/components/navbar/navbar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/navbar/navbar.html b/zeppelin-web/src/components/navbar/navbar.html
index cf8b5b6..c9a3f56 100644
--- a/zeppelin-web/src/components/navbar/navbar.html
+++ b/zeppelin-web/src/components/navbar/navbar.html
@@ -27,7 +27,7 @@ limitations under the License.
       <ul class="nav navbar-nav" ng-if="ticket">
         <li class="dropdown notebook-list-dropdown" dropdown>
           <a href="#" class="dropdown-toggle" data-toggle="dropdown" dropdown-toggle>Notebook <span class="caret"></span></a>
-          <ul class="dropdown-menu navbar-dropdown-maxHeight" role="menu">
+          <ul class="dropdown-menu" role="menu">
             <li ng-controller="NotenameCtrl as notenamectrl"><a href="" data-toggle="modal" data-target="#noteNameModal" ng-click="notenamectrl.getInterpreterSettings()"><i class="fa fa-plus"></i> Create new note</a></li>
             <li class="divider"></li>
             <div id="notebook-list" class="scrollbar-container" ng-if="isDrawNavbarNoteList">