[GitHub] [helix] NealSun96 commented on a diff in pull request #2357: Enable MSDS auto refresh for DedicatedZkClient

["NealSun96 (via GitHub)" <gi...@apache.org>]

NealSun96 commented on code in PR #2357:
URL: https://github.com/apache/helix/pull/2357#discussion_r1091278958


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/routing/RoutingDataManager.java:
##########
@@ -175,6 +178,15 @@ public synchronized void reset() {
     _lastResetTimestamp = System.currentTimeMillis();
   }
 
+  public synchronized void reset(boolean enforceThrottle) {

Review Comment:
   This one is "resetWithThrottle", the above one is technically "forceReset". I didn't want to change it and inflate PR size, but I'm leaning towards changing it now. I can 
   1. Change it to be `reset(false)` and make `reset()` private; 
   2. or change it to be `forceReset()`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org