You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/16 13:04:47 UTC

[GitHub] [flink] alpinegizmo commented on a diff in pull request #20070: [FLINK-28202][ci] Generalize utils around shade plugin

alpinegizmo commented on code in PR #20070:
URL: https://github.com/apache/flink/pull/20070#discussion_r1023968218


##########
tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/utils/shade/ShadeParser.java:
##########
@@ -46,7 +46,6 @@ public final class ShadeParser {
                             + "(?<groupId>.*?):"
                             + "(?<artifactId>.*?):"
                             + "(?<type>.*?):"
-                            + "(?:(?<classifier>.*?):)?"

Review Comment:
   Sure, okay. Baby steps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org