[jira] Updated: (MAHOUT-230) Replace org.apache.mahout.math.Sorting with code of clear provenance

["Benson Margulies (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAHOUT-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benson Margulies updated MAHOUT-230:
------------------------------------

    Attachment: replace-sorting.diff

Here is the new Sorting.java. The patch is, of course, illegible. Apply it and read the results.

> Replace org.apache.mahout.math.Sorting with code of clear provenance
> --------------------------------------------------------------------
>
>                 Key: MAHOUT-230
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-230
>             Project: Mahout
>          Issue Type: Bug
>          Components: Math
>    Affects Versions: 0.3
>            Reporter: Benson Margulies
>             Fix For: 0.3
>
>         Attachments: replace-sorting.diff
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> org.apache.mahout.math.Sorting looks as if the original author borrowed from the Sun JRE, based on the private internal function names and contents. That code has a restrictive license. We need to take the equivalent file (java.util.Arrays) from Apache Harmony and use it as the basis for a clean replacement.
> The problematic code are the quickSort and mergeSort functions, which extend 'Arrays' by supporting slices of arrays and custom sorting predicate functions. 
> One might also wistfully note that the more recent JDKs from Sun have deployed different (and one hopes) better sort algorithms that 1.5 and/or Harmony, so a really energetic person might build implementations in here to match. However, expediency calls for just bashing on the Harmony implementation to solve the problem at hand.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.