[GitHub] [incubator-druid] leventov commented on a change in pull request #6948: Add guava compatability up to 27.0.1

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #6948: Add guava compatability up to 27.0.1
URL: https://github.com/apache/incubator-druid/pull/6948#discussion_r303486010
 
 

 ##########
 File path: extensions-core/kafka-extraction-namespace/src/main/java/org/apache/druid/query/lookup/KafkaLookupExtractorFactory.java
 ##########
 @@ -262,7 +262,7 @@ public void onFailure(Throwable t)
               }
             }
           },
-          Execs.directExecutor()
+          Runnable::run
 
 Review comment:
   I think it's better to create a method like `GuavaUtils.directExecutor()` which returns `Runnable::run`. Bare `Runnable::run` looks somewhat puzzling. There are also other calls to `Runnable::run` in this PR which are subject for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org