You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by wujinhu <gi...@git.apache.org> on 2016/11/13 12:48:54 UTC

[GitHub] incubator-eagle pull request #648: [EAGLE-757] fix alert JdbcDatabaseHandler...

GitHub user wujinhu opened a pull request:

    https://github.com/apache/incubator-eagle/pull/648

    [EAGLE-757] fix alert JdbcDatabaseHandler connection issue

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wujinhu/incubator-eagle EAGLE-757

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #648
    
----
commit 2dc4bbdbb6427d566411de9a59a3fd922661b83e
Author: wujinhu <wu...@126.com>
Date:   2016-11-13T12:28:18Z

    fix alert JdbcDatabaseHandler connection issue

commit 0eb2deda42d941f1cb61d5fdc4e4fb7daf890126
Author: wujinhu <wu...@126.com>
Date:   2016-11-13T12:42:08Z

    Merge branch 'master' of https://github.com/apache/incubator-eagle into EAGLE-757
    
    # Conflicts:
    #	eagle-core/eagle-metadata/eagle-metadata-jdbc/src/main/java/org/apache/eagle/metadata/store/jdbc/JDBCDataSourceConfig.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #648: [EAGLE-757] fix alert JdbcDatabaseHandler connec...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:

    https://github.com/apache/incubator-eagle/pull/648
  
    LGTM, besides follow suggestions:
    
    * Merge `alertDao` into `metadata.store`, probably by simply override system property
    * Handle possible runtime exception during object mapping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #648: [EAGLE-757] fix alert JdbcDatabaseHandler...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/648


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---