You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/31 11:40:12 UTC
[GitHub] [hadoop-ozone] cxorm opened a new pull request #402: HDDS-2815. Fix
list bucket for --start parameter
cxorm opened a new pull request #402: HDDS-2815. Fix list bucket for --start parameter
URL: https://github.com/apache/hadoop-ozone/pull/402
## What changes were proposed in this pull request?
This PR was created to let ```--start``` work well in listing buckets.
- Fix.
List buckets including bucket that was assigned by ```--start``` parameter,
and update the corresponding UT.
And finally fix the ```BucketIterator``` to work well with the CLI.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2815
## How was this patch tested?
UT updated.
Ran the CLI command on my standalone cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on issue #402: HDDS-2815. Fix shell
description for --start parameter of listing buckets
Posted by GitBox <gi...@apache.org>.
cxorm commented on issue #402: HDDS-2815. Fix shell description for --start parameter of listing buckets
URL: https://github.com/apache/hadoop-ozone/pull/402#issuecomment-571334284
Thanks @nandakumar131 for the review, and @xiaoyuyao for the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #402: HDDS-2815. Fix
shell description for --start parameter of listing buckets
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #402: HDDS-2815. Fix shell description for --start parameter of listing buckets
URL: https://github.com/apache/hadoop-ozone/pull/402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request
#402: HDDS-2815. Fix shell description for --start parameter of listing
buckets
Posted by GitBox <gi...@apache.org>.
nandakumar131 commented on a change in pull request #402: HDDS-2815. Fix shell description for --start parameter of listing buckets
URL: https://github.com/apache/hadoop-ozone/pull/402#discussion_r363224202
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/ListBucketHandler.java
##########
@@ -51,7 +51,7 @@
private int maxBuckets;
@Option(names = {"--start", "-s"},
- description = "The first bucket to start the listing")
+ description = "The listing will start from bucket after the startBucket.")
Review comment:
Suggestion: The bucket to start the listing from. This will be excluded from the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on issue #402: HDDS-2815. Fix shell
description for --start parameter of listing buckets
Posted by GitBox <gi...@apache.org>.
cxorm commented on issue #402: HDDS-2815. Fix shell description for --start parameter of listing buckets
URL: https://github.com/apache/hadoop-ozone/pull/402#issuecomment-570780254
> Please don't review and commit this PR for now.
> There is something to discuss.
> Thanks.
Sorry for the change.
The change is completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #402: HDDS-2815. Fix
shell description for --start parameter of listing buckets
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #402: HDDS-2815. Fix shell description for --start parameter of listing buckets
URL: https://github.com/apache/hadoop-ozone/pull/402#issuecomment-571324742
Thanks @cxorm for the patch. LGTM and will merge it shortly based on weekly meeting this morning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #402: HDDS-2815. Fix
shell description for --start parameter of listing buckets
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #402: HDDS-2815. Fix shell description for --start parameter of listing buckets
URL: https://github.com/apache/hadoop-ozone/pull/402#issuecomment-571226940
Let's commit this and fix the issue in a separate JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on issue #402: HDDS-2815. Fix list
bucket for --start parameter
Posted by GitBox <gi...@apache.org>.
cxorm commented on issue #402: HDDS-2815. Fix list bucket for --start parameter
URL: https://github.com/apache/hadoop-ozone/pull/402#issuecomment-570567854
Please don't review and commit this PR for now.
There is something to discuss.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #402:
HDDS-2815. Fix shell description for --start parameter of listing buckets
Posted by GitBox <gi...@apache.org>.
cxorm commented on a change in pull request #402: HDDS-2815. Fix shell description for --start parameter of listing buckets
URL: https://github.com/apache/hadoop-ozone/pull/402#discussion_r363344164
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/ListBucketHandler.java
##########
@@ -51,7 +51,7 @@
private int maxBuckets;
@Option(names = {"--start", "-s"},
- description = "The first bucket to start the listing")
+ description = "The listing will start from bucket after the startBucket.")
Review comment:
Thanks @nandakumar131 for the review.
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org