You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/02/28 23:23:09 UTC
[PR] [SPARK-47216][DOCS] Refine layout of SQL performance tuning page [spark]
nchammas opened a new pull request, #45322:
URL: https://github.com/apache/spark/pull/45322
### What changes were proposed in this pull request?
- Add a new introduction.
- Rename some section headings.
- Group the paragraphs on query hints with related tuning techniques.
- Minor grammar fixes in some places.
### Why are the changes needed?
These changes organize the various tuning techniques a bit better than before so they are easier to map out mentally. This will also make it easier to make future improvements to this page (which I intend to do in follow-up PRs).
### Does this PR introduce _any_ user-facing change?
Yes.
Master is on the left; this branch is on the right. Here is how the first page changed:
<img width="1470" alt="Screenshot 2024-02-28 at 6 16 36 PM" src="https://github.com/apache/spark/assets/1039369/6450525b-69e7-4dce-936f-78c61baaabc1">
The table of contents gives a quick view of the changes.
If you'd like to see more, here are full screenshots of the whole page:
- [sql-tuning-performance-master](https://github.com/apache/spark/assets/1039369/822476d7-c2f7-4546-98bd-28a50fc54de6)
- [sql-tuning-performance-branch](https://github.com/apache/spark/assets/1039369/412b1697-f64f-4360-9381-cf21390cb958)
### How was this patch tested?
Built the docs and reviewed them locally.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47216][DOCS] Refine layout of SQL performance tuning page [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45322: [SPARK-47216][DOCS] Refine layout of SQL performance tuning page
URL: https://github.com/apache/spark/pull/45322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47216][DOCS] Refine layout of SQL performance tuning page [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45322:
URL: https://github.com/apache/spark/pull/45322#issuecomment-1973801912
+1, LGTM. Merging to master.
Thank you, @nchammas and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org