You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/11/29 14:25:38 UTC

[GitHub] [incubator-eventmesh] pchengma commented on pull request #2292: [ISSUE #2291] Knative test code add assertion

pchengma commented on PR #2292:
URL: https://github.com/apache/incubator-eventmesh/pull/2292#issuecomment-1330729161

   Hi @jonyangx, I think this commit is really helpful. Thanks for your contribution!
   
   By the way, although we have passed an integration test for the [Knative InMemoryChannel-backed broker](https://knative.dev/docs/getting-started/first-broker/), the unit tests of the knative-connector are not fully covered for each function right now. 
   
   LGTM for your commit.
   
   @xwm1992 Please merge this PR if there is no more question from the other community members.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org