You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/08 23:27:26 UTC
[GitHub] [pinot] deemoliu opened a new issue #7549: Make dim tables creation(for Pinot lookup join) bypass the offline tenant table validation
deemoliu opened a new issue #7549:
URL: https://github.com/apache/pinot/issues/7549
Per #6286, pinot lookup join feature require offline dim table to be created in the same tenant with fact table.
However if the fact table is in realtime tenant, all the hosts in the tenant configs are shown as below.
```
{
"id": "host_name",
"simpleFields": {
"HELIX_ENABLED": "true",
"HELIX_ENABLED_TIMESTAMP": "1583445083986",
"HELIX_HOST": "host_name",
"HELIX_PORT": "7177"
},
"mapFields": {},
"listFields": {
"TAG_LIST": [
"tenantName_REALTIME"
]
}
}
```
In this realtime tenant, Dim tables are offline tables, Pinot disallow the offline dim table to be deployed, due to the below
[validation](https://github.com/apache/pinot/blob/30f5490968f1c34f00f431f55a7c10a9cfe5cd9c/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java#L1261 ) .
```
for (String tag : tagsToCheck) {
if (getInstancesWithTag(tag).isEmpty()) {
throw new InvalidTableConfigException(
"Failed to find instances with tag: " + tag + " for table: " + tableNameWithType);
}
}
```
Can we make dim tables bypass the offline tenant table validation so that it can be deployed to tenant with realtime hosts as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #7549: Make dim tables creation(for Pinot lookup join) bypass the offline tenant table validation
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #7549:
URL: https://github.com/apache/pinot/issues/7549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] deemoliu edited a comment on issue #7549: Make dim tables creation(for Pinot lookup join) bypass the offline tenant table validation
Posted by GitBox <gi...@apache.org>.
deemoliu edited a comment on issue #7549:
URL: https://github.com/apache/pinot/issues/7549#issuecomment-939177401
@chenboat @yupeng9 @Jackie-Jiang @dharakk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] deemoliu commented on issue #7549: Make dim tables creation(for Pinot lookup join) bypass the offline tenant table validation
Posted by GitBox <gi...@apache.org>.
deemoliu commented on issue #7549:
URL: https://github.com/apache/pinot/issues/7549#issuecomment-939177401
@chenboat @yupeng9 @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org