You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/07/23 06:32:09 UTC

[GitHub] [incubator-kyuubi] zhang1002 opened a new pull request #861: Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

zhang1002 opened a new pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861


   ### _Why are the changes needed?_
   
   When the SQL is running, we want to get all metrics in its ruuning time. Those metrics can help us to analyse the conf is reasonable or not and how to improve the perference.
   When the SQL is failed, we need to know what causes it.
   Above these reason, we need to add some event tracking to collect those metrics.
   
   For kyuubiStageInfo, there have some labels.
   You can use statementId to get all stages' info that belong to this SQL. 
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #861: [KYUUBI #845] Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861#discussion_r675380572



##########
File path: externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/KyuubiStatementMonitorSuite.scala
##########
@@ -118,6 +118,29 @@ class KyuubiStatementMonitorSuite extends WithSparkSQLEngine with HiveJDBCTests
     }
   }
 
+  test("add kyuubiStageInfo into queue") {
+    val sql = "select timestamp'2021-06-01'"
+    val getQueue = PrivateMethod[
+      ArrayBlockingQueue[KyuubiStageInfo]](Symbol("kyuubiStageInfoQueue"))()
+    val kyuubiStageQueue = KyuubiStatementMonitor.invokePrivate(getQueue)
+    kyuubiStageQueue.clear()
+    withSessionHandle { (client, handle) =>
+      val req = new TExecuteStatementReq()
+      req.setSessionHandle(handle)
+      req.setStatement(sql)
+      val tExecuteStatementResp = client.ExecuteStatement(req)
+      val opHandle = tExecuteStatementResp.getOperationHandle
+
+      eventually(timeout(10.seconds), interval(100.milliseconds)) {
+        assert(kyuubiStageQueue.size() === 1)
+
+        val kyuubiStageInfo = kyuubiStageQueue.peek()
+        assert(kyuubiStageInfo.statementId === OperationHandle(opHandle).identifier.toString)
+        assert(kyuubiStageInfo.stageInfo.completionTime !== None)

Review comment:
       nit: .nonEmpty




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #861: Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861#issuecomment-885436862


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#861](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55f1351) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7ee92ce5c1831fa20e62c1a703fd0564416f75cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ee92ce) will **increase** coverage by `0.31%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #861      +/-   ##
   ============================================
   + Coverage     78.60%   78.91%   +0.31%     
     Complexity       10       10              
   ============================================
     Files           135      136       +1     
     Lines          5122     5275     +153     
     Branches        641      656      +15     
   ============================================
   + Hits           4026     4163     +137     
   - Misses          745      759      +14     
   - Partials        351      353       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../engine/spark/monitor/KyuubiStatementMonitor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL0t5dXViaVN0YXRlbWVudE1vbml0b3Iuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...bi/engine/spark/monitor/entity/KyuubiJobInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlKb2JJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [.../engine/spark/monitor/entity/KyuubiStageInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGFnZUluZm8uc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ine/spark/monitor/entity/KyuubiStatementInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGF0ZW1lbnRJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `88.46% <100.00%> (ø)` | |
   | [...g/apache/spark/kyuubi/SparkSQLEngineListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrU1FMRW5naW5lTGlzdGVuZXIuc2NhbGE=) | `87.50% <100.00%> (+0.96%)` | :arrow_up: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `94.70% <0.00%> (+0.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ee92ce...55f1351](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #861: Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861#issuecomment-885436862


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#861](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55f1351) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7ee92ce5c1831fa20e62c1a703fd0564416f75cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ee92ce) will **decrease** coverage by `0.15%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #861      +/-   ##
   ============================================
   - Coverage     78.60%   78.45%   -0.16%     
     Complexity       10       10              
   ============================================
     Files           135      136       +1     
     Lines          5122     5137      +15     
     Branches        641      642       +1     
   ============================================
   + Hits           4026     4030       +4     
   - Misses          745      756      +11     
     Partials        351      351              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../engine/spark/monitor/KyuubiStatementMonitor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL0t5dXViaVN0YXRlbWVudE1vbml0b3Iuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...bi/engine/spark/monitor/entity/KyuubiJobInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlKb2JJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [.../engine/spark/monitor/entity/KyuubiStageInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGFnZUluZm8uc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ine/spark/monitor/entity/KyuubiStatementInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGF0ZW1lbnRJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `88.46% <100.00%> (ø)` | |
   | [...g/apache/spark/kyuubi/SparkSQLEngineListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrU1FMRW5naW5lTGlzdGVuZXIuc2NhbGE=) | `87.50% <100.00%> (+0.96%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ee92ce...55f1351](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] zhang1002 closed pull request #861: [KYUUBI #845] Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
zhang1002 closed pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #861: [KYUUBI #845] Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861#issuecomment-885436862


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#861](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fbc3315) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7ee92ce5c1831fa20e62c1a703fd0564416f75cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ee92ce) will **decrease** coverage by `0.12%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #861      +/-   ##
   ============================================
   - Coverage     78.60%   78.47%   -0.13%     
     Complexity       10       10              
   ============================================
     Files           135      136       +1     
     Lines          5122     5138      +16     
     Branches        641      643       +2     
   ============================================
   + Hits           4026     4032       +6     
   - Misses          745      756      +11     
   + Partials        351      350       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../engine/spark/monitor/KyuubiStatementMonitor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL0t5dXViaVN0YXRlbWVudE1vbml0b3Iuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...bi/engine/spark/monitor/entity/KyuubiJobInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlKb2JJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [.../engine/spark/monitor/entity/KyuubiStageInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGFnZUluZm8uc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ine/spark/monitor/entity/KyuubiStatementInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGF0ZW1lbnRJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `88.46% <100.00%> (ø)` | |
   | [...g/apache/spark/kyuubi/SparkSQLEngineListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrU1FMRW5naW5lTGlzdGVuZXIuc2NhbGE=) | `87.50% <100.00%> (+0.96%)` | :arrow_up: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `94.06% <0.00%> (+0.01%)` | :arrow_up: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmtfMy4xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (+0.98%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ee92ce...fbc3315](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #861: [KYUUBI #845] Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861#issuecomment-885436862


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#861](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fbc3315) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7ee92ce5c1831fa20e62c1a703fd0564416f75cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ee92ce) will **increase** coverage by `0.33%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #861      +/-   ##
   ============================================
   + Coverage     78.60%   78.93%   +0.33%     
     Complexity       10       10              
   ============================================
     Files           135      136       +1     
     Lines          5122     5275     +153     
     Branches        641      655      +14     
   ============================================
   + Hits           4026     4164     +138     
   - Misses          745      759      +14     
   - Partials        351      352       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../engine/spark/monitor/KyuubiStatementMonitor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL0t5dXViaVN0YXRlbWVudE1vbml0b3Iuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...bi/engine/spark/monitor/entity/KyuubiJobInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlKb2JJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [.../engine/spark/monitor/entity/KyuubiStageInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGFnZUluZm8uc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ine/spark/monitor/entity/KyuubiStatementInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGF0ZW1lbnRJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `88.46% <100.00%> (ø)` | |
   | [...g/apache/spark/kyuubi/SparkSQLEngineListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrU1FMRW5naW5lTGlzdGVuZXIuc2NhbGE=) | `87.50% <100.00%> (+0.96%)` | :arrow_up: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `94.70% <0.00%> (+0.65%)` | :arrow_up: |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmtfMy4xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `80.39% <0.00%> (+0.98%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ee92ce...fbc3315](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #861: [KYUUBI #845] Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861#issuecomment-885436862


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#861](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55f1351) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/7ee92ce5c1831fa20e62c1a703fd0564416f75cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ee92ce) will **increase** coverage by `0.31%`.
   > The diff coverage is `33.33%`.
   
   > :exclamation: Current head 55f1351 differs from pull request most recent head fbc3315. Consider uploading reports for the commit fbc3315 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #861      +/-   ##
   ============================================
   + Coverage     78.60%   78.91%   +0.31%     
     Complexity       10       10              
   ============================================
     Files           135      136       +1     
     Lines          5122     5275     +153     
     Branches        641      656      +15     
   ============================================
   + Hits           4026     4163     +137     
   - Misses          745      759      +14     
   - Partials        351      353       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../engine/spark/monitor/KyuubiStatementMonitor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL0t5dXViaVN0YXRlbWVudE1vbml0b3Iuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...bi/engine/spark/monitor/entity/KyuubiJobInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlKb2JJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [.../engine/spark/monitor/entity/KyuubiStageInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGFnZUluZm8uc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ine/spark/monitor/entity/KyuubiStatementInfo.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1tb25pdG9yL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9tb25pdG9yL2VudGl0eS9LeXV1YmlTdGF0ZW1lbnRJbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   | [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `88.46% <100.00%> (ø)` | |
   | [...g/apache/spark/kyuubi/SparkSQLEngineListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrU1FMRW5naW5lTGlzdGVuZXIuc2NhbGE=) | `87.50% <100.00%> (+0.96%)` | :arrow_up: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/861/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `94.70% <0.00%> (+0.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ee92ce...fbc3315](https://codecov.io/gh/apache/incubator-kyuubi/pull/861?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #861: [KYUUBI #845] Event tracking for stageInfo: Getting metrics in stage's lifecycle and store them in mem

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #861:
URL: https://github.com/apache/incubator-kyuubi/pull/861#discussion_r675408600



##########
File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/entity/KyuubiStageInfo.scala
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.spark.monitor.entity
+
+import org.apache.spark.scheduler.StageInfo
+
+/**
+ * This object is used for storing the basic data for stage.
+ * StageInfo store the metrics in its running time.
+ *
+ * In this object, you can use jobId to get all stages that belong to this job and also
+ * you can use statementId to get all stages.
+ *
+ * @param stageId
+ * @param statementId
+ * @param stageInfo
+ */
+// TODO: kyuubi-851: Thread safe consider: for statementInfo, jobInfo and stageInfo
+case class KyuubiStageInfo(
+    stageId: Int,
+    statementId: String,
+    stageInfo: StageInfo)

Review comment:
       Can we merge all info bean into one file ?

##########
File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/entity/KyuubiStageInfo.scala
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.spark.monitor.entity
+
+import org.apache.spark.scheduler.StageInfo
+
+/**
+ * This object is used for storing the basic data for stage.
+ * StageInfo store the metrics in its running time.
+ *
+ * In this object, you can use jobId to get all stages that belong to this job and also
+ * you can use statementId to get all stages.
+ *
+ * @param stageId
+ * @param statementId
+ * @param stageInfo
+ */
+// TODO: kyuubi-851: Thread safe consider: for statementInfo, jobInfo and stageInfo
+case class KyuubiStageInfo(
+    stageId: Int,
+    statementId: String,
+    stageInfo: StageInfo)

Review comment:
       Do we need all fields of `StageInfo` ?

##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkSQLEngineListener.scala
##########
@@ -112,6 +112,13 @@ class SparkSQLEngineListener(server: Serverable) extends SparkListener with Logg
    }
   }
 
+  override def onStageSubmitted(stageSubmitted: SparkListenerStageSubmitted): Unit = {
+    val statementId = stageSubmitted.properties.getProperty(KYUUBI_STATEMENT_ID_KEY)
+    val kyuubiStageInfo = KyuubiStageInfo(
+      stageSubmitted.stageInfo.stageId, statementId, stageSubmitted.stageInfo)
+    KyuubiStatementMonitor.putStageInfoIntoQueue(kyuubiStageInfo)
+  }
+

Review comment:
       Why we don't capture `SparkListenerStageCompleted` ?

##########
File path: externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/KyuubiStatementMonitor.scala
##########
@@ -57,33 +56,43 @@ object KyuubiStatementMonitor extends Logging{
    *      a. time
    *      b. this map's current size
    */
-  // TODO: Capacity should make configurable
   private val kyuubiJobIdToJobInfoMap = new ConcurrentHashMap[Int, KyuubiJobInfo](maxCapacity)
 
+  /**
+   * This blockingQueue store kyuubiStageInfo.
+   *
+   * Notice:
+   *    1. When we remove items from this queue, we should ensure those stages have finished
+   *       If not, we should put them into this queue again.
+   *    2. There have two kinds of threshold to trigger when to remove items from this queue:
+   *      a. time
+   *      b. this queue's current size
+   */
+  private val kyuubiStageInfoQueue = new ArrayBlockingQueue[KyuubiStageInfo](maxCapacity)
+
   /**
    * This method is used for putting kyuubiStatementInfo into blockingQueue(statementQueue).
    * Every time we put an item into this queue, we should judge this queue's current size at first.
    * If the size is less than threshold, we need to remove items from this queue.
    *
    * @param kyuubiStatementInfo
    */
-  // TODO: Lack size type threshold and time type threshold
+  // TODO: kyuubi-850: Make threshold that trigger when to dump data into file configurable
   def putStatementInfoIntoQueue(kyuubiStatementInfo: KyuubiStatementInfo): Unit = {
     if (kyuubiStatementQueue.size() >= maxSize) {
       removeAndDumpStatementInfoFromQueue()
     }
     val isSuccess = kyuubiStatementQueue.add(kyuubiStatementInfo)
-    info(s"Add kyuubiStatementInfo into queue is [$isSuccess], " +
+    debug(s"Add kyuubiStatementInfo into queue is [$isSuccess], " +

Review comment:
       It's better that move the unrelated code to a new PR. It can help reviewer get the main change of this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org