[GitHub] [spark] amaliujia commented on a diff in pull request #38023: [SPARK-40587][CONNECT] Support SELECT * in an explicit way in connect proto

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38023:
URL: https://github.com/apache/spark/pull/38023#discussion_r981760665


##########
connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -155,4 +156,7 @@ message Expression {
     string expression = 1;
   }
 
+  // represent * (e.g. SELECT *)
+  message UnresolvedStar {
+  }

Review Comment:
   We need to expand this message later to support full fields of the star:
   ```
   case class UnresolvedStar(target: Option[Seq[String]]) extends Star with Unevaluable {
   
   ```
   
   which is will be used to support `Struct`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org