[GitHub] [hudi] nsivabalan commented on a diff in pull request #8128: [HUDI-5782] Tweak defaults and remove unnecessary configs after config review

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #8128:
URL: https://github.com/apache/hudi/pull/8128#discussion_r1152611317


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -288,9 +288,6 @@ private HoodieWriteConfig createMetadataWriteConfig(
         .withCompactionConfig(HoodieCompactionConfig.newBuilder()
             .withInlineCompaction(false)
             .withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
-            // by default, the HFile does not keep the metadata fields, set up as false
-            // to always use the metadata of the new record.
-            .withPreserveCommitMetadata(false)

Review Comment:
   sorry, default value for preserveCommitMetadata is true. but for hfile(MDT), meta fields are disable and hence we need to re-create and not preserve. can you help me clarify. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org