You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/04/01 12:35:51 UTC
Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter
in Mesos allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45529/
-----------------------------------------------------------
(Updated April 1, 2016, 12:35 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-5073
https://issues.apache.org/jira/browse/MESOS-5073
Repository: mesos
Description
-------
Do not leak roleSorter and quotaRoleSorter in Mesos allocator.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd
src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132
Diff: https://reviews.apache.org/r/45529/diff/
Testing
-------
make check (OS X, clang trunk, not optimized)
In https://reviews.apache.org/r/45534/ I add code requiring cleanup to `Sorter`s. Without this patch the cleanup code is never executed, but is with the patch.
Thanks,
Benjamin Bannier
Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter
in Mesos allocator.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45529/
-----------------------------------------------------------
(Updated April 5, 2016, 11:15 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Addressed review comment from Joris.
Bugs: MESOS-5073
https://issues.apache.org/jira/browse/MESOS-5073
Repository: mesos
Description
-------
Do not leak roleSorter and quotaRoleSorter in Mesos allocator.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd
src/master/allocator/mesos/hierarchical.cpp cd6b91edf3dde9bc4c978daefdfc83d7c3c69304
Diff: https://reviews.apache.org/r/45529/diff/
Testing
-------
make check (OS X, clang trunk, not optimized)
In https://reviews.apache.org/r/45534/ I add code requiring cleanup to `Sorter`s. Without this patch the cleanup code is never executed, but is with the patch.
Thanks,
Benjamin Bannier
Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter
in Mesos allocator.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45529/#review127187
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.cpp (lines 611 - 612)
<https://reviews.apache.org/r/45529/#comment190351>
Mind adding a `CHECK(frameworkSorters.contains(role))` here?
- Joris Van Remoortere
On April 1, 2016, 10:35 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45529/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 10:35 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-5073
> https://issues.apache.org/jira/browse/MESOS-5073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not leak roleSorter and quotaRoleSorter in Mesos allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e979fdf60da1409d1c2d08f0e9f03cef067506dd
> src/master/allocator/mesos/hierarchical.cpp 5a5df5f8287a1f85b8b2a6aac7e6e13d0650a132
>
> Diff: https://reviews.apache.org/r/45529/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang trunk, not optimized)
>
> In https://reviews.apache.org/r/45534/ I add code requiring cleanup to `Sorter`s. Without this patch the cleanup code is never executed, but is with the patch.
>
>
> Thanks,
>
> Benjamin Bannier
>
>