You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/20 01:08:11 UTC
[kudu-CR] build-support: add a nicer logger to python scripts
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10131
to review the following change.
Change subject: build-support: add a nicer logger to python scripts
......................................................................
build-support: add a nicer logger to python scripts
Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
---
M build-support/build_source_release.py
M build-support/check_compatibility.py
M build-support/clang_tidy_gerrit.py
M build-support/dist_test.py
M build-support/gen_version_info.py
M build-support/iwyu.py
M build-support/kudu_util.py
M build-support/push_to_asf.py
8 files changed, 42 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/10131/1
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] build-support: add a nicer logger to python scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts
......................................................................
Patch Set 2:
(1 comment)
Ah, that's nice. I have one question though.
http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py
File build-support/kudu_util.py:
http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py@49
PS2, Line 49: ColorFilter()
Should this depend on sys.stdout.isatty() ? In other words, do we want extra color symbols when we just redirect logs into a file?
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 20 Apr 2018 01:58:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-support: add a nicer logger to python scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py
File build-support/kudu_util.py:
http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py@49
PS2, Line 49: ColorFilter()
> The 'Colors' constants already turn into empty strings on non-TTY output
Oh, nice to know, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 05:51:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-support: add a nicer logger to python scripts
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py
File build-support/kudu_util.py:
http://gerrit.cloudera.org:8080/#/c/10131/2/build-support/kudu_util.py@49
PS2, Line 49: ColorFilter()
> Should this depend on sys.stdout.isatty() ? In other words, do we want ext
The 'Colors' constants already turn into empty strings on non-TTY output
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 05:17:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-support: add a nicer logger to python scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts
......................................................................
build-support: add a nicer logger to python scripts
Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Reviewed-on: http://gerrit.cloudera.org:8080/10131
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/build_source_release.py
M build-support/check_compatibility.py
M build-support/clang_tidy_gerrit.py
M build-support/dist_test.py
M build-support/gen_version_info.py
M build-support/iwyu.py
M build-support/kudu_util.py
M build-support/push_to_asf.py
8 files changed, 42 insertions(+), 23 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build-support: add a nicer logger to python scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 05:52:04 +0000
Gerrit-HasComments: No
[kudu-CR] build-support: add a nicer logger to python scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build-support: add a nicer logger to python scripts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10131 )
Change subject: build-support: add a nicer logger to python scripts
......................................................................
Patch Set 2:
Unrelated flake in MultiThreadedTabletTest/5.DeleteAndReinsert.
--
To view, visit http://gerrit.cloudera.org:8080/10131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic648fadfbb11eb3e0a8f137ae3f3143e52149101
Gerrit-Change-Number: 10131
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 20 Apr 2018 05:51:57 +0000
Gerrit-HasComments: No