You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/15 04:10:16 UTC
[GitHub] [nifi] joewitt opened a new pull request #4058: NIFI-7157 first
attempt at a basic github workflow CI action
joewitt opened a new pull request #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #4058: NIFI-7157 first
attempt at a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-586810691
@joewitt, can you clarify what this change means for contributors? I test my pr's in my personal travis, will this work the same way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #4058: NIFI-7157 first
attempt at a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-589017976
How can I test this? I don't see any indication of actions running or anything. Is there something that should be there to see?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #4058: NIFI-7157 first attempt at
a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-589020619
if you want to watch progress as I'm learning this thing https://github.com/joewitt/nifi/actions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards edited a comment on issue #4058: NIFI-7157
first attempt at a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
ottobackwards edited a comment on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-587561626
Will github actions just work in our forks? or is there some kind of opt-in signup that we need to have done?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #4058: NIFI-7157 first
attempt at a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-587561626
Will github actions just work in our forks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #4058: NIFI-7157 first attempt at
a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-589019268
Im guessing all of us are new to the github actions stuff. Please read/review the links provided in the JIRA. I am testing and learning this by pushing to my own fork and evaluating. This PR is just part of an early attempt to see how it will impact in the nifi repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #4058: NIFI-7157 first
attempt at a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-589024757
Thanks @joewitt, this is great. It is an interesting case as to how you would do a PR *on actions* and have them reviewed though ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #4058: NIFI-7157 first attempt at
a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-587556468
If adopted it means we'd no longer utilize travis-ci for build verification to ease PR handling process but would instead use github actions/ci processes. You could certainly still use whatever personal process you like. You'd have to maintain your own travis config in your repo though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #4058: NIFI-7157 first attempt at
a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058#issuecomment-587574347
I believe it will as that is how I'm currently testing this PR but could be wrong. In terms of the community managed repo it will run on any pull request or update to a pull request or as things land on master (just like travis is supposed to).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] asfgit closed pull request #4058: NIFI-7157 first attempt at
a basic github workflow CI action
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4058: NIFI-7157 first attempt at a basic github workflow CI action
URL: https://github.com/apache/nifi/pull/4058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services