You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Min Chen <mi...@citrix.com> on 2014/04/30 07:15:07 UTC
[ACS4.4] Cherry pick several IAM bug fixes
Hi Hugo/Daan,
Would you please cherry-pick the following IAM bug fixes from 4.4-forward branch to 4.4 branch?
Commit : 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are not working.
Commit: 092b4be8d91e2e63aea12e1d40aa264e144e6d84
CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
deployment flow
Commit: a4cb8d11462cb404eba067541639d46e509d717b
CLOUDSTACK-6513: IAM - Templates - When templates are listed with
templatefilter="shared" is used , we see public templates also being
included in the list.
Commit: b2b59ed83a566762c960371717b7998b4719ba70
CLOUDSTACK-6533: IAM - Templates - Public templates do not have
permissions to be used by ROOT group.
Commit: 0767060b1f4cf96db721bd625971345fbda4c48c
CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
affinity groups available for regular users by passing account and
domainId paramater.
Commit:7309146f9f3f57b7f7cad40945e11e34a6ff6fab
CLOUDSTACK-6513: Optimize code by removing deprecated utility to
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
CLOUDSTACK-6513: templateFilter=shared should not show self-owned
template.
Thanks.
-min
Re: [ACS4.4] Cherry pick several IAM bug fixes
Posted by Min Chen <mi...@citrix.com>.
Looks good to me, thanks, Daan
-min
On 5/1/14 1:41 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>min, I put what I did inline. It seems strange to me so please check
>if the result what you want.
>
>On Wed, Apr 30, 2014 at 7:41 PM, Min Chen <mi...@citrix.com> wrote:
>> Hi Daan,
>>
>> I have fixed those two commits. Could you please cherry-pick the
>> following commits from 4.4-forward to 4.4 branch/
>>
>> 1. CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py
>>are
>> not working.
>> Commit: 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
>does not apply. not applied.
>
>> Commit: 42b803dd4b6e01107cbcf08d87f17c47934e8ae7
>that one is applied (without the previous).
>
>>
>> 2. CLOUDSTACK-6513: templateFilter=shared should not show self-owned
>> template.
>> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
>applied
>> Commit: 412793f9b41bb03eda2b8474f9f22a12b5097327
>does not apply without the previous. applied
>
>regards,
>--
>Daan
Re: [ACS4.4] Cherry pick several IAM bug fixes
Posted by Daan Hoogland <da...@gmail.com>.
min, I put what I did inline. It seems strange to me so please check
if the result what you want.
On Wed, Apr 30, 2014 at 7:41 PM, Min Chen <mi...@citrix.com> wrote:
> Hi Daan,
>
> I have fixed those two commits. Could you please cherry-pick the
> following commits from 4.4-forward to 4.4 branch/
>
> 1. CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
> not working.
> Commit: 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
does not apply. not applied.
> Commit: 42b803dd4b6e01107cbcf08d87f17c47934e8ae7
that one is applied (without the previous).
>
> 2. CLOUDSTACK-6513: templateFilter=shared should not show self-owned
> template.
> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
applied
> Commit: 412793f9b41bb03eda2b8474f9f22a12b5097327
does not apply without the previous. applied
regards,
--
Daan
Re: [ACS4.4] Cherry pick several IAM bug fixes
Posted by Min Chen <mi...@citrix.com>.
Hi Daan,
I have fixed those two commits. Could you please cherry-pick the
following commits from 4.4-forward to 4.4 branch/
1. CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
not working.
Commit: 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
Commit: 42b803dd4b6e01107cbcf08d87f17c47934e8ae7
2. CLOUDSTACK-6513: templateFilter=shared should not show self-owned
template.
Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
Commit: 412793f9b41bb03eda2b8474f9f22a12b5097327
Thanks
-min
On 4/30/14 9:39 AM, "Min Chen" <mi...@citrix.com> wrote:
>Thanks Daan. I am addressing those two commits now.
>
>-min
>
>On 4/30/14 1:42 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>
>>Min,
>>
>>see inline
>>
>>On Wed, Apr 30, 2014 at 7:15 AM, Min Chen <mi...@citrix.com> wrote:
>>> Hi Hugo/Daan,
>>>
>>> Would you please cherry-pick the following IAM bug fixes from
>>>4.4-forward branch to 4.4 branch?
>>>
>>> Commit : 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
>>this contains some trailing spaces in the altered lines, can you please
>>amend?
>>
>>> CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
>>>not working.
>>>
>>> Commit: 092b4be8d91e2e63aea12e1d40aa264e144e6d84
>>done
>>
>>> CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
>>> deployment flow
>>>
>>> Commit: a4cb8d11462cb404eba067541639d46e509d717b
>>done
>>
>>> CLOUDSTACK-6513: IAM - Templates - When templates are listed with
>>> templatefilter="shared" is used , we see public templates also being
>>> included in the list.
>>>
>>> Commit: b2b59ed83a566762c960371717b7998b4719ba70
>>done
>>
>>> CLOUDSTACK-6533: IAM - Templates - Public templates do not have
>>> permissions to be used by ROOT group.
>>>
>>> Commit: 0767060b1f4cf96db721bd625971345fbda4c48c
>>done
>>
>>> CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
>>> affinity groups available for regular users by passing account and
>>> domainId paramater.
>>>
>>> Commit:7309146f9f3f57b7f7cad40945e11e34a6ff6fab
>>done
>>
>>> CLOUDSTACK-6513: Optimize code by removing deprecated utility to
>>> QueryManagerImpl as private method just used for listTemplates and
>>> listAffinityGroups to avoid misuse by new list APIs.
>>>
>>> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
>>contains code in comment, can you please delete?
>>
>>> CLOUDSTACK-6513: templateFilter=shared should not show self-owned
>>> template.
>>>
>>> Thanks.
>>> -min
>>
>>
>>regards
>>--
>>Daan
>
Re: [ACS4.4] Cherry pick several IAM bug fixes
Posted by Min Chen <mi...@citrix.com>.
Thanks Daan. I am addressing those two commits now.
-min
On 4/30/14 1:42 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>Min,
>
>see inline
>
>On Wed, Apr 30, 2014 at 7:15 AM, Min Chen <mi...@citrix.com> wrote:
>> Hi Hugo/Daan,
>>
>> Would you please cherry-pick the following IAM bug fixes from
>>4.4-forward branch to 4.4 branch?
>>
>> Commit : 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
>this contains some trailing spaces in the altered lines, can you please
>amend?
>
>> CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
>>not working.
>>
>> Commit: 092b4be8d91e2e63aea12e1d40aa264e144e6d84
>done
>
>> CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
>> deployment flow
>>
>> Commit: a4cb8d11462cb404eba067541639d46e509d717b
>done
>
>> CLOUDSTACK-6513: IAM - Templates - When templates are listed with
>> templatefilter="shared" is used , we see public templates also being
>> included in the list.
>>
>> Commit: b2b59ed83a566762c960371717b7998b4719ba70
>done
>
>> CLOUDSTACK-6533: IAM - Templates - Public templates do not have
>> permissions to be used by ROOT group.
>>
>> Commit: 0767060b1f4cf96db721bd625971345fbda4c48c
>done
>
>> CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
>> affinity groups available for regular users by passing account and
>> domainId paramater.
>>
>> Commit:7309146f9f3f57b7f7cad40945e11e34a6ff6fab
>done
>
>> CLOUDSTACK-6513: Optimize code by removing deprecated utility to
>> QueryManagerImpl as private method just used for listTemplates and
>> listAffinityGroups to avoid misuse by new list APIs.
>>
>> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
>contains code in comment, can you please delete?
>
>> CLOUDSTACK-6513: templateFilter=shared should not show self-owned
>> template.
>>
>> Thanks.
>> -min
>
>
>regards
>--
>Daan
Re: [ACS4.4] Cherry pick several IAM bug fixes
Posted by Daan Hoogland <da...@gmail.com>.
Min,
see inline
On Wed, Apr 30, 2014 at 7:15 AM, Min Chen <mi...@citrix.com> wrote:
> Hi Hugo/Daan,
>
> Would you please cherry-pick the following IAM bug fixes from 4.4-forward branch to 4.4 branch?
>
> Commit : 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
this contains some trailing spaces in the altered lines, can you please amend?
> CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are not working.
>
> Commit: 092b4be8d91e2e63aea12e1d40aa264e144e6d84
done
> CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
> deployment flow
>
> Commit: a4cb8d11462cb404eba067541639d46e509d717b
done
> CLOUDSTACK-6513: IAM - Templates - When templates are listed with
> templatefilter="shared" is used , we see public templates also being
> included in the list.
>
> Commit: b2b59ed83a566762c960371717b7998b4719ba70
done
> CLOUDSTACK-6533: IAM - Templates - Public templates do not have
> permissions to be used by ROOT group.
>
> Commit: 0767060b1f4cf96db721bd625971345fbda4c48c
done
> CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
> affinity groups available for regular users by passing account and
> domainId paramater.
>
> Commit:7309146f9f3f57b7f7cad40945e11e34a6ff6fab
done
> CLOUDSTACK-6513: Optimize code by removing deprecated utility to
> QueryManagerImpl as private method just used for listTemplates and
> listAffinityGroups to avoid misuse by new list APIs.
>
> Commit: 3af2f6d1418c66533067b5050d2fe3fd4200beb9
contains code in comment, can you please delete?
> CLOUDSTACK-6513: templateFilter=shared should not show self-owned
> template.
>
> Thanks.
> -min
regards
--
Daan