[GitHub] [arrow-datafusion] mingmwang commented on pull request #4185: Add rule to reimplement `Eliminate cross join` and remove it in planner

[GitBox <gi...@apache.org>]

mingmwang commented on PR #4185:
URL: https://github.com/apache/arrow-datafusion/pull/4185#issuecomment-1319502555

   There is specific logic in `extract_possible_join_keys()` to handle and pull up common Exprs in the Or branches.
   But I think this logic should be handled in a common rule like `ExprSimplifier`.
   @alamb 
   Once we reach the other rules, Exprs in Filters or Join conditions should be the already simplified form.
   
   ````
   (A.a = B.b and B.x = xxx) or (A.a = B.b and B.y = yyy)
   ````
   To
   ````
   (A.a = B.b) and (B.x = xxx or B.y = yyy)
   ````
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org