You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/13 15:39:47 UTC

[GitHub] [shardingsphere] smartbetter opened a new pull request, #22154: Update SQLStatement log level(#21764)

smartbetter opened a new pull request, #22154:
URL: https://github.com/apache/shardingsphere/pull/22154

   Fixes #21764.
   
   Update SQLStatement log level to DEBUG.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1032866189


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   I created a new issue to discuss about remove it. #22453



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] smartbetter commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
smartbetter commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1032885647


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   > I created a new issue to discuss removing it. #22453
   
   Okay, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] smartbetter closed pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
smartbetter closed pull request #22154: Update SQLStatement log level(#21764)
URL: https://github.com/apache/shardingsphere/pull/22154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1032865592


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   Sorry, ShardingSphere is a public project, it should not upon to one person's requirement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1028931853


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   How about move it to `logNormalMode`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] smartbetter commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
smartbetter commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1029034329


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   > How about move it to `logNormalMode`?
   
   I don't need SQLStatement log, SQLStatement prints too much. But I need logNormalMode logs.
   I think SQLStatement log to debug would be better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] smartbetter commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
smartbetter commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1029034329


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   > How about move it to `logNormalMode`?
   
   I don't need `SQLStatement` log, SQLStatement prints too much. But I need `logNormalMode` logs.
   I think SQLStatement log to debug would be better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#issuecomment-1321914245

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22154](https://codecov.io/gh/apache/shardingsphere/pull/22154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd9d6f6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a3408201f2480dcd91dc5ae3874dd95ff54f7a66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a340820) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #22154      +/-   ##
   ============================================
   - Coverage     51.04%   51.04%   -0.01%     
     Complexity     2512     2512              
   ============================================
     Files          4160     4160              
     Lines         57695    57695              
     Branches       9790     9790              
   ============================================
   - Hits          29451    29449       -2     
   - Misses        25709    25710       +1     
   - Partials       2535     2536       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ardingsphere/infra/executor/sql/log/SQLLogger.java](https://codecov.io/gh/apache/shardingsphere/pull/22154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9sb2cvU1FMTG9nZ2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...authentication/OpenGaussAuthenticationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/22154/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9mcm9udGVuZC9vcGVuZ2F1c3MvYXV0aGVudGljYXRpb24vT3BlbkdhdXNzQXV0aGVudGljYXRpb25IYW5kbGVyLmphdmE=) | `85.33% <0.00%> (-2.67%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] smartbetter commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
smartbetter commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1029034329


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   > How about move it to `logNormalMode`?
   
   I don't need SQLStatement log, but I need logNormalMode logs. I think SQLStatement log to debug would be better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #22154: Update SQLStatement log level(#21764)

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #22154:
URL: https://github.com/apache/shardingsphere/pull/22154#discussion_r1032866189


##########
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java:
##########
@@ -44,7 +44,7 @@ public final class SQLLogger {
      */
     public static void logSQL(final QueryContext queryContext, final boolean showSimple, final ExecutionContext executionContext) {
         log("Logic SQL: {}", queryContext.getSql());
-        log("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());
+        log.debug("SQLStatement: {}", queryContext.getSqlStatementContext().getSqlStatement());

Review Comment:
   I created a new issue to discuss removing it. #22453



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org