[jira] Resolved: (WSRP4J-44) ConsumerParameters can never be set in org.apache.wsrp4j.consumer.portlet.impl.URLGeneratorImpl

["Diego Louzán (JIRA)" <ws...@ws.apache.org>]

     [ http://issues.apache.org/jira/browse/WSRP4J-44?page=all ]
     
Diego Louzán resolved WSRP4J-44:
--------------------------------

      Assign To: Diego Louzán
     Resolution: Fixed
    Fix Version: current (nightly)

> ConsumerParameters can never be set in org.apache.wsrp4j.consumer.portlet.impl.URLGeneratorImpl
> -----------------------------------------------------------------------------------------------
>
>          Key: WSRP4J-44
>          URL: http://issues.apache.org/jira/browse/WSRP4J-44
>      Project: WSRP4J
>         Type: Bug
>   Components: Consumer
>     Versions: current (nightly)
>     Reporter: Diego Louzán
>     Assignee: Diego Louzán
>      Fix For: current (nightly)

>
> In class org.apache.wsrp4j.consumer.portlet.impl.URLGeneratorImpl (lines 155 & 234):
> if (consumerParameters != null)
> {
>     Iterator iter2 = consumerParameters.keySet().iterator();
>     String name = null;
>     String value = null;
>     while (iter2.hasNext())
>     {
>         if ((value = (String)consumerParameters.get(name)) != null)
>         {
>             url.setParameter(name, value);
>         }
>     }
> }
> This code can never set consumerParameters to the url, because the next element of the iterator is never called. Insert a call to next() to resolve it:
> if (consumerParameters != null)
> {
>     Iterator iter2 = consumerParameters.keySet().iterator();
>     String name = null;
>     String value = null;
>     while (iter2.hasNext())
>     {
>         name = (String) iter2.next();
>         if ((value = (String)consumerParameters.get(name)) != null)
>         {
>             url.setParameter(name, value);
>         }
>     }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira